Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: Access-Control-Expose-Headers: * #5047

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 6, 2017

Belated test for whatwg/fetch#252.

@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm and @youennf. (Learn how reviewing works.)

@ghost
Copy link

ghost commented Mar 6, 2017

These tests are now available on w3c-test.org

@ghost
Copy link

ghost commented Mar 6, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 06e4d7b
Using browser at version BuildID 20170306110339; SourceStamp 966464a68a2cb3ca1125808e34abb5c1d34e3797
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-expose-star-worker.html
Subtest Results Messages
OK
Basic Access-Control-Expose-Headers: * support FAIL assert_equals: expected (string) "X" but got (object) null
Cannot use * for credentialed fetches PASS {}
/fetch/api/cors/cors-expose-star.html
Subtest Results Messages
OK
Basic Access-Control-Expose-Headers: * support FAIL assert_equals: expected (string) "X" but got (object) null
Cannot use * for credentialed fetches PASS

@ghost
Copy link

ghost commented Mar 6, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 06e4d7b
Using browser at version 58.0.3026.3 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-expose-star-worker.html
Subtest Results Messages
OK
Basic Access-Control-Expose-Headers: * support FAIL assert_equals: expected (string) "X" but got (object) null
Cannot use * for credentialed fetches PASS {}
/fetch/api/cors/cors-expose-star.html
Subtest Results Messages
OK
Basic Access-Control-Expose-Headers: * support FAIL assert_equals: expected (string) "X" but got (object) null
Cannot use * for credentialed fetches PASS

const url = "http://{{host}}:{{ports[http][1]}}" + dirname(location.pathname) + RESOURCES_DIR + "top.txt",
sharedHeaders = "?pipe=header(Access-Control-Expose-Headers,*)|header(Test,X)|header(Set-Cookie,X)|"

promise_test(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having looked for and not found the use of the argument, I removed it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing the impl bugs, there was some discussion on whatwg/fetch#252 but let's see if any more concerns appear. Until then, the tests LGTM.

assert_equals(resp.headers.get("test"), null)
assert_equals(resp.headers.get("set-cookie"), null)
})
}, "Cannot use * for credentialed fetches")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this also gives me some confidence that the above test will pass if the feature is implemented 👍

@annevk annevk merged commit e563af0 into master Mar 7, 2017
@annevk annevk deleted the annevk/cors-expose-headers branch March 7, 2017 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants