-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch: Access-Control-Expose-Headers: * #5047
Conversation
Belated test for whatwg/fetch#252.
Notifying @jdm and @youennf. (Learn how reviewing works.) |
These tests are now available on w3c-test.org |
Firefox (nightly channel)Testing web-platform-tests at revision 06e4d7b All results2 tests ran/fetch/api/cors/cors-expose-star-worker.html
/fetch/api/cors/cors-expose-star.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 06e4d7b All results2 tests ran/fetch/api/cors/cors-expose-star-worker.html
/fetch/api/cors/cors-expose-star.html
|
const url = "http://{{host}}:{{ports[http][1]}}" + dirname(location.pathname) + RESOURCES_DIR + "top.txt", | ||
sharedHeaders = "?pipe=header(Access-Control-Expose-Headers,*)|header(Test,X)|header(Set-Cookie,X)|" | ||
|
||
promise_test(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having looked for and not found the use of the argument, I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing the impl bugs, there was some discussion on whatwg/fetch#252 but let's see if any more concerns appear. Until then, the tests LGTM.
assert_equals(resp.headers.get("test"), null) | ||
assert_equals(resp.headers.get("set-cookie"), null) | ||
}) | ||
}, "Cannot use * for credentialed fetches") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, this also gives me some confidence that the above test will pass if the feature is implemented 👍
Belated test for whatwg/fetch#252.