Stop using Chrome's automation extension for testharness tests #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents ChromeDriver from using its automation extension for testharness-based tests. When this extension is used, Chrome displays a warning bar that changes the window size while a test is already running, and this can cause test flake. This change only affects testharness-based tests since older versions of Chrome (like the currently shipping Chrome 59) require the extension for reftests (in order to set the window size).
Firefox (nightly)Testing web-platform-tests at revision ff0a286 |
Sauce (safari)Testing web-platform-tests at revision ff0a286 |
Chrome (unstable)Testing web-platform-tests at revision ff0a286 |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision ff0a286 |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents ChromeDriver from using its automation extension for
testharness-based tests. When this extension is used, Chrome displays
a warning bar that changes the window size while a test is already
running, and this can cause test flake (IntersectionObserver tests
are running into this; also see this discussion thread).
This change only affects testharness-based tests since older versions
of Chrome (like the currently shipping Chrome 59) require the extension
for reftests (in order to set the window size).
This change is