Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5501: multicol test linking to self as reference #7462

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Sep 25, 2017

The reference here is pulled from presto-testo (from revision b5d5d519321bb6da4bc825f92c3f4e84db31be6f).

Fixes #5501.


This change is Reviewable

The reference here is pulled from presto-testo (from revision
b5d5d519321bb6da4bc825f92c3f4e84db31be6f).
@ghost
Copy link

ghost commented Sep 25, 2017

Build PASSED

Started: 2017-09-25 11:15:34
Finished: 2017-09-25 11:25:51

View more information about this build on:

Copy link
Contributor

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy with the original test having neither assertion nor comments saying anything about what it's trying to test, nor with the dead code it has, but the new ref looks fine, and isn't guilty for the sins of its father, so to speak. Approving.

@frivoal frivoal merged commit cdcb657 into web-platform-tests:master Sep 25, 2017
@gsnedders gsnedders deleted the multicol-same-file-ref branch September 25, 2017 12:55
@gsnedders
Copy link
Member Author

Yeah, I'm just glad I found a ref for it in presto-testo, means I don't need to figure out what the rendering should be. :)

@rachelandrew
Copy link
Contributor

I'm hoping to find time to do a review of the state of the multicol test suite as part of my work on the spec. So feel free to raise issues and add me to them.

@frivoal
Copy link
Contributor

frivoal commented Sep 25, 2017

@rachelandrew You're a saint. I started two stub bugs about issues found in this test. I'm sure there's many more with the same problems, but this gives us a place to start collecting the issues:
#7469
#7470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants