Add DataTransferItem getAsString test #8693
Conversation
Build PASSEDStarted: 2017-12-15 02:45:52 View more information about this build on: |
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
wpt-pr-bot
requested review from
annevk,
domenic,
foolip and
zcorpan
and removed request for
ayg
| <meta charset="utf-8"> | ||
| <title>DataTransferItem Test: getAsString()</title> | ||
| <link rel="author" title="Intel" href="http://www.intel.com"> | ||
| <meta name="flags" content="interact"> |
| <script src="/resources/testharnessreport.js"></script> | ||
|
|
||
| <p><input id="button" type="text" value="dragcharacters" style="border:2px blue solid; width:200px; height: 100px;"/></p> | ||
| <p><input id="div" type="text" style="border:2px green solid; width:200px; height: 100px;"/></p> |
There was a problem hiding this comment.
These IDs are fairly confusing since they are not buttons or divs.
| let div; | ||
|
|
||
| setup(function() { | ||
| div = document.getElementById("div"); |
There was a problem hiding this comment.
This doesn't need to be inside the setup function, right? Might as well put it outside, and just call setup with a single argument.
|
@domenic, many thanks for your review! I just submit a new commit to address your comments, PTAL. |
|
Could you rebase this on master due to the Taskcluster configuration change? Sorry :/ |
- remove meta element which name is flags - rewrite setup function - use more appropriate id
xiuqijix
force-pushed
the
kangxu_DataTransferItem
branch
from
d3c3fe7 to
6ecd9b1
Compare
|
@domenic, CI checks are all pass, it's ready for merge. :) |
No description provided.