Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Правит баги генерации изображений для GIF #350

Merged
merged 9 commits into from
Oct 21, 2023
Merged

Правит баги генерации изображений для GIF #350

merged 9 commits into from
Oct 21, 2023

Conversation

monochromer
Copy link
Member

@monochromer monochromer commented Oct 21, 2023 •
edited by pepelsbey
Loading

Sharp сейчас не умеет создавать анимированные AVIF, поэтому генерируем только WebP.

Также Eleventy Image некорректно задаёт высоту для GIF-изображений. Она получается равной высота * <число кадров>. Поэтому задаём размеры сами:

const height = imageElement.getAttribute('height') ?? sharpImageMetaData.pageHeight ?? sharpImageMetaData.height;

Попутно сделал небольшой рефакторинг, убрав повторяющиеся части в отдельную функцию.

@pepelsbey
Copy link
Member

О, я как раз создал #351 — это оно?

@monochromer
Copy link
Member Author

Ага

@monochromer
Copy link
Member Author

monochromer commented Oct 21, 2023 •
edited
Loading

Вернее, и этот PR тоже.

pepelsbey
pepelsbey approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Огонь :) Спасибо

@pepelsbey pepelsbey merged commit 56ec91c into web-standards-ru:main Oct 21, 2023
5 checks passed
@pepelsbey pepelsbey mentioned this pull request Oct 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monochromer @pepelsbey