Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): fix memory leak when passing keepAlive #83

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

MichaelDeBoey
Copy link
Contributor

See @marwan38's remix-run#24 & @donavon's remix-run#29

This is a direct copy of node-fetch/node-fetch#1474.

We're having memory leak issues as we're using a http agent with keepAlive options with the fetch used on the remix server.

CC/ @alanshaw @Gozala


#77 needs to be merged first

@MichaelDeBoey MichaelDeBoey marked this pull request as draft August 26, 2023 20:05
@Gozala
Copy link
Contributor

Gozala commented Aug 28, 2023

@MichaelDeBoey I'v attempted to resolve merge conflicts and reviewed changes. Have not merged it since PR is marked as a draft. If it's done feel free to merge.

@MichaelDeBoey MichaelDeBoey force-pushed the memory-leak-keepAlive branch from 9064ba2 to f72070d Compare August 29, 2023 00:33
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review August 29, 2023 00:33
@MichaelDeBoey
Copy link
Contributor Author

@Gozala I don't have permissions to merge this branch, so you will need to do it
If you wish to add more maintainers to this package, I know @jacob-ebey and I would be happy to help out

@Gozala
Copy link
Contributor

Gozala commented Aug 29, 2023

@Gozala I don't have permissions to merge this branch, so you will need to do it

I have invited to the contributors team earlier today, once you accept the invite you should be able to merge.

If you wish to add more maintainers to this package, I know @jacob-ebey and I would be happy to help out

Inviting @jacob-ebey to the team as well

@Gozala Gozala merged commit 5fde362 into web-std:main Aug 29, 2023
@MichaelDeBoey MichaelDeBoey deleted the memory-leak-keepAlive branch August 29, 2023 01:24
@MichaelDeBoey
Copy link
Contributor Author

I have invited to the contributors team earlier today, once you accept the invite you should be able to merge.

Didn't see that yet 🙈
Accepted now 😉

Inviting @jacob-ebey to the team as well

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants