Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Frontend preview flag information not working in TYPO3 v12 anymore #395

Closed
sbuerk opened this issue Dec 12, 2024 · 0 comments · Fixed by #398
Closed

[BUG] Frontend preview flag information not working in TYPO3 v12 anymore #395

sbuerk opened this issue Dec 12, 2024 · 0 comments · Fixed by #398
Assignees
Labels
bug Something isn't working Version 4.x Version 5.x

Comments

@sbuerk
Copy link
Contributor

sbuerk commented Dec 12, 2024

Describe the bug

Preview flag information are not displayed in TYPO3 v12.

To Reproduce

  • Translate a page and content to a language using one of the DeepL translation modes
  • Ensure that translated page is "hidden"
  • Preview hidden translated page in the frontend using the preview button for the language.

Expected behavior

Information are displayed at least similar to TYPO3 v11.

Screenshots

  • TYPO3 v11
    image

  • TYPO3 v12

image

TYPO3 Setup

  • DeepL Version: 4.x, 5.x(main)
  • TYPO3 Version: v12.4.24
  • Server apache-fpm
  • Database type and version: MariaDB 10.4
  • PHP version: PHP 8.1
  • DeepL free or paid API? free
  • composer or classic setup? composer mode

Additional context

TYPO3 v12 removed a couple of hooks in 12.0 in favour of new PSR-14 events.

  • For 4.x event needs to be added beside the hook which should be working
    out of the box.
  • For 5.x the event should be adopted and the hook implementation removed.

Links:

@sbuerk sbuerk added bug Something isn't working Version 4.x Version 5.x labels Dec 12, 2024
@sbuerk sbuerk self-assigned this Dec 14, 2024
sbuerk added a commit that referenced this issue Dec 14, 2024
Issue #395 has been recently fixed for 4.x and 5.x
with following pull-requests:

* #397
* #398

Adding regression test has been omited due to issues within the
`typo3/testing-framework` already. The major missing part boils
down to an incomplete frontend backend user authentication setup,
reported by Daniel Siepmann [1] and provided a pull-request [2].

* [1] Issue: TYPO3/testing-framework#535
* [2] Pull-request: TYPO3/testing-framework#536

The pull-request has been adopted by providing a test-fixture
extension replacing the BackendUserHandler with a fixed version.
Sadly, this required an additional temporary workaround within
the functional test bootstrap, enforce loading package infor for
the testing-framework extensions. That needs to be fixed within
`typo3/testing-framework`, enforce loading the package info in
Testbase->linkFrameworkExtensionsToInstance` when linking the
framework extension - or refactor the linking all together.

For ongoing work to add TYPO3 v13 support we take the workarounds
to continue the work having regression test in place and do not
wait until resolved in the testing-framework which needs adoptions
in the TYPO3 monorepo and therefore some coordination in fix, release
and upgrade.

SiteBasedTestTrait related reporting for new test case are added
to the baseline for now, needs to be addressed in general with
a dedcated change.

Used command(s):

```bash
Build/Scripts/runTests.sh -t 12 -p 8.1 -s phpstanGenerateBaseline
```

Related: #395
Related: #398
Related: #397
sbuerk added a commit that referenced this issue Dec 14, 2024
Issue #395 has been recently fixed for 4.x and 5.x
with following pull-requests:

* #397
* #398

Adding regression test has been omited due to issues within the
`typo3/testing-framework` already. The major missing part boils
down to an incomplete frontend backend user authentication setup,
reported by Daniel Siepmann [1] and provided a pull-request [2].

* [1] Issue: TYPO3/testing-framework#535
* [2] Pull-request: TYPO3/testing-framework#536

The pull-request has been adopted by providing a test-fixture
extension replacing the BackendUserHandler with a fixed version.
Sadly, this required an additional temporary workaround within
the functional test bootstrap, enforce loading package infor for
the testing-framework extensions. That needs to be fixed within
`typo3/testing-framework`, enforce loading the package info in
Testbase->linkFrameworkExtensionsToInstance` when linking the
framework extension - or refactor the linking all together.

For ongoing work to add TYPO3 v13 support we take the workarounds
to continue the work having regression test in place and do not
wait until resolved in the testing-framework which needs adoptions
in the TYPO3 monorepo and therefore some coordination in fix, release
and upgrade.

SiteBasedTestTrait related reporting for new test case are added
to the baseline for now, needs to be addressed in general with
a dedcated change.

Used command(s):

```bash
Build/Scripts/runTests.sh -t 12 -p 8.1 -s phpstanGenerateBaseline
```

Related: #395
Related: #398
Related: #397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Version 4.x Version 5.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant