[BUGFIX] Use TYPO3 configured proxy for deepl client #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuerk
requested changes
May 23, 2024
When converting the client, the proxy configuration via TYPO3 was no longer taken into account. This will be made up for with this change.
NarkNiro
force-pushed
the
deepl-proxy-config
branch
from
a8e9918 to
587daf6
Compare
sbuerk
approved these changes
May 23, 2024
|
Thank you very much! |
sbuerk
pushed a commit
to staempfli-webteam/wv_deepltranslate
that referenced
this pull request
Jun 10, 2024
With web-vision#331 the TYPO3 proxy setting has been validated and set as `DeepL Guzzle Client` transport option to have a proper configured proxy used. The TYPO3 proxy setting however allows setting it as a single string url or as array for different protocols, which is not respected. This change modifies the `AbstractClient->getTranslator()` implementation to handle this double structure for named option correctly now. Related: web-vision#331
sbuerk
pushed a commit
to staempfli-webteam/wv_deepltranslate
that referenced
this pull request
Jun 10, 2024
With web-vision#331 the TYPO3 proxy setting has been validated and set as `DeepL Guzzle Client` transport option to have a proper configured proxy used. The TYPO3 proxy setting however allows setting it as a single string url or as array for different protocols, which is not respected. This change modifies the `AbstractClient->getTranslator()` implementation to handle this double structure for named option correctly now. Related: web-vision#331
sbuerk
pushed a commit
to staempfli-webteam/wv_deepltranslate
that referenced
this pull request
Jun 10, 2024
With web-vision#331 the TYPO3 proxy setting has been validated and set as `DeepL Guzzle Client` transport option to have a proper configured proxy used. The TYPO3 proxy setting however allows setting it as a single string url or as array for different protocols, which is not respected. This change modifies the `AbstractClient->getTranslator()` implementation to handle this double structure for named option correctly now. [1] https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/Configuration/Typo3ConfVars/HTTP.html#typo3ConfVars_http_proxy Related: web-vision#331
Mabahe
added a commit
to Mabahe/wv_deepltranslate
that referenced
this pull request
Oct 22, 2024
Since all $GLOBALS['TYPO3_CONF_VARS']['HTTP'] options should be respected we can simple use the built in client. Also 'proxy' is respected in this case, so we don't need a extra setting for this. Resolves: web-vision#370 Relates: web-vision#331
Mabahe
added a commit
to Mabahe/wv_deepltranslate
that referenced
this pull request
Oct 22, 2024
Since all $GLOBALS['TYPO3_CONF_VARS']['HTTP'] options should be respected we can simple use the built in client. Also 'proxy' is respected in this case, so we don't need a extra setting for this. Resolves: web-vision#370 Relates: web-vision#331
Mabahe
added a commit
to Mabahe/wv_deepltranslate
that referenced
this pull request
Oct 22, 2024
Since all $GLOBALS['TYPO3_CONF_VARS']['HTTP'] options should be respected we can simple use the built in client. Also 'proxy' is respected in this case, so we don't need a extra setting for this. Resolves: web-vision#370 Relates: web-vision#331
Mabahe
added a commit
to Mabahe/wv_deepltranslate
that referenced
this pull request
Oct 22, 2024
Since all $GLOBALS['TYPO3_CONF_VARS']['HTTP'] options should be respected we can simple use the built in client. Also 'proxy' is respected in this case, so we don't need a extra setting for this. Resolves: web-vision#370 Relates: web-vision#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting the client, the proxy configuration via TYPO3 was no longer taken into account. This will be made up for with this change.
resolve #330