[TASK] Ensure failing php-cs-fixer within Github Action pipeline
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the dry-run flag (`-n`) to the php-cs-fixer code-quality execution within the Github Action workflow file to emit an non-zero exit code when changes are detected to ensure failing job-run in this case.
This change applies `php-cs-fixer` modifications which slipped into the code-base because the corresponding code-quality check missed the dry-run flag and doesn't fail when changes has been detected.
NarkNiro
approved these changes
Dec 12, 2024
sbuerk
added a commit
that referenced
this pull request
Dec 12, 2024
This change applies `php-cs-fixer` modifications which slipped into the code-base because the corresponding code-quality check missed the dry-run flag and doesn't fail when changes has been detected. Backport of #384.
sbuerk
added a commit
that referenced
this pull request
Dec 12, 2024
This change applies `php-cs-fixer` modifications which slipped into the code-base because the corresponding code-quality check missed the dry-run flag and doesn't fail when changes has been detected. Backport of #384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the dry-run flag (
-n) to the php-cs-fixercode-quality execution within the Github Action workflow file
to emit an non-zero exit code when changes are detected to
ensure failing job-run in this case.
Second commit applies php-cs-fixer to get the pipeline green,
which validates that it works again.