[TASK] Upgrade to typo3/testing-framework 8.x #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typo3/testing-framework` supports testing against two TYPO3 versions per TF version and the current used 7.x supports only TYPO3 v11 and v12. After TYPO3 v11 support has been dropped, this change upgrades the development dependency to the next version and bolldozes the towards adding TYPO3 v13 as second supported TYPO3 version. Used command(s): ```shell composer require --dev \ "typo3/testing-framework":"^8.2.7" ```
The `SiteBasedTestTrait` uses `AbstractInstruction` to declare native types for method arguments and return types and PHPStan complains about this because `typo3/testing-framework` methods uses the `InstructionInterface` instead. This change adopts `InstructionInterface` type hints to be in line with the `typo3/testing-framework` and satisfy PHPStan, which allows us to remove no longer matched ignored errors from the PHPStan baseline. Used command(s): ```shell Build/Scripts/runTests.sh -t 12 -p 8.1 -s phpstanGenerateBaseline ```
NarkNiro
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Update to
typo3/testing-frameworkversion 8.xtypo3/testing-frameworksupports testing against twoTYPO3 versions per TF version and the current used 7.x
supports only TYPO3 v11 and v12.
After TYPO3 v11 support has been dropped, this change
upgrades the development dependency to the next version
and bolldozes the towards adding TYPO3 v13 as second
supported TYPO3 version.
Used command(s):
[TASK] Use better suiting typing in
SiteBasedTestTraitThe
SiteBasedTestTraitusesAbstractInstructionto declarenative types for method arguments and return types and PHPStan
complains about this because
typo3/testing-frameworkmethodsuses the
InstructionInterfaceinstead.This change adopts
InstructionInterfacetype hints to be inline with the
typo3/testing-frameworkand satisfy PHPStan,which allows us to remove no longer matched ignored errors from
the PHPStan baseline.
Used command(s):