Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip CORS test and remove dependency on ipfs.io gateway in tests #923

Closed
alanshaw opened this issue Jan 28, 2022 · 0 comments · Fixed by #992
Closed

Unskip CORS test and remove dependency on ipfs.io gateway in tests #923

alanshaw opened this issue Jan 28, 2022 · 0 comments · Fixed by #992
Labels
need/triage Needs initial labeling and prioritization P3 Low: Not priority right now topic/pot Issues handled by PT.

Comments

@alanshaw
Copy link
Member

A CORS test that uses the ipfs.io gatewayhas been skipped. This needs to be re-enabled and at the same time we should remove that dependency by using a gateway from an IPFS node we're already running in docker for the tests.

See: #902 (comment)
@alanshaw alanshaw added the need/triage Needs initial labeling and prioritization label Jan 28, 2022
@alanshaw alanshaw changed the title Fix CORS test and remove dependency on ipfs.io gateway in tests Unskip CORS test and remove dependency on ipfs.io gateway in tests Jan 28, 2022
@alanshaw alanshaw mentioned this issue Jan 28, 2022
Merged
@dchoi27 dchoi27 added P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Jan 28, 2022
@flea89 flea89 mentioned this issue Feb 18, 2022
Merged
@flea89 flea89 linked a pull request Feb 18, 2022 that will close this issue
Move GATEWAY to env and expose ipfs gateway #992
Merged
@flea89 flea89 added topic/pot Issues handled by PT. need/triage Needs initial labeling and prioritization labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization P3 Low: Not priority right now topic/pot Issues handled by PT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move GATEWAY to env and expose ipfs gateway web3-storage/web3.storage
3 participants
@alanshaw @flea89 @dchoi27