Move GATEWAY to env and expose ipfs gateway #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flea89
force-pushed
the
fix/gateway-local-env
branch
2 times, most recently
from
e7b9c2a
to
3bb5898
Compare
flea89
force-pushed
the
fix/gateway-local-env
branch
from
f0c5c70
to
b1b99a7
Compare
LeslieOA
added
kind/enhancement
| @@ -43,7 +43,7 @@ bindings = [{ name = "NAME_ROOM", class_name = "NameRoom0" }] | |||
| account_id = "fffa4b4363a7e5250af8357087263b3a" # Protocol Labs CF account | |||
| zone_id = "7eee3323c1b35b6650568604c65f441e" # web3.storage zone | |||
| route = "https://api.web3.storage/*" | |||
| vars = { CLUSTER_API_URL = "https://web3.storage.ipfscluster.io/api/", ENV = "production", PG_REST_URL = "https://web3-storage-pgrest-prod.herokuapp.com" } | |||
| vars = { CLUSTER_API_URL = "https://web3.storage.ipfscluster.io/api/", ENV = "production", PG_REST_URL = "https://web3-storage-pgrest-prod.herokuapp.com", GATEWAY_URL = "https://ipfs.io" } | |||
There was a problem hiding this comment.
Can we add this to staging and other envs?
There was a problem hiding this comment.
Good catch!
We definitively need staging to point to https://ipfs.io
For other cloudfare dev envs I would suggest we keep the https://ipfs.io (rather than the local version) to avoid having to create another tunnel, would you agree?
Honestly, I expect now that we have miniflare, that devs would use that for development rather than this (in most cases) so it shouldn't be a big deal, would you agree?
There was a problem hiding this comment.
Yes, let's point to ipfs.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Moving GATEWAY to environment to allow to point to dockerized ipfs gateway in development.