feat!: add continuous deployment to cron package #1281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1129
🚫 Before merging to main
cron-v1.0.0
to point to the latest main. This can be done on the merge commit of this PR in main?Rationale
Cron jobs should be running on the latest "released" cron package tag.
This is achieved by checking out the latest tag in the cron workflows.
Nice To Have
The current implementation should work for existing jobs but it doesn't really prevent to have new jobs to be "missconfigured" (note checkouting latest tag).
It'd be nice to have a check in the scripts themselves, something like
cron/src/index.js
and then use run-func to run the different jobs like this:
cron/package.json
What do you think?