feat: can disable new user registration at /user/login API around w3up launch by setting NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_START
#2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_STARTNEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_START
gobengo
force-pushed
the
rm-new-user-api-1699488141
branch
from
953e27d
to
675844f
Compare
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
…can pikc up on it
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
… and redirects to new page /login/signups-closed/try-w3up/
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
gobengo
had a problem deploying
to
preview-2324/merge
GitHub Actions
Failure
…le in website to avoid headaches with jsx in api mocha
|
I tested on the preview link (https://b1bf40ff.web3-storage-staging.pages.dev) and was able to sign in just fine. This is as expected, because the preview link doesn't have the limited availability mode enabled. I'll enable it on staging once we merge this and test there |
alanshaw
approved these changes
Nov 13, 2023
This was referenced Nov 13, 2023
|
this seems to be working well on staging |
gobengo
pushed a commit
that referenced
this pull request
Nov 13, 2023
🤖 I have created a release *beep* *boop* --- ## [7.21.0](api-v7.20.0...api-v7.21.0) (2023-11-13) ### Features * can disable new user registration at /user/login API around w3up launch by setting `NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_START` ([#2324](#2324)) ([09a59c6](09a59c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
gobengo
pushed a commit
that referenced
this pull request
Nov 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.38.0](website-v2.37.0...website-v2.38.0) (2023-11-13) ### Features * /account/payment disables changing plans after scheduled sunset date ([#2321](#2321)) ([22799fe](22799fe)) * can disable new user registration at /user/login API around w3up launch by setting `NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_START` ([#2324](#2324)) ([09a59c6](09a59c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
What
w3up-launchmodule into a new package that both can depend on@web3-storage/w3up-launch@web3-storage/apiloginOrRegisterreads env.NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_STARTand if its after that, will throw an error when it would otherwise create a new user./login/signups-closed/try-w3up/