Refactor Pin APIs and PR feedback #810

flea89 · 2021-12-16T18:09:46Z

In #726 we've received really good feedback and, to avoid pushing the updates directly to that feature branch, we've been working on this PR.

The scope of this PR is mostly:

Refactor pin_request to create content and related pins on PinRequest creation.
Tackle all the related feedback and quick wins from Pinning APIs #726. (we've updated the comments there to point this out)

Please be aware that not every single point of feedback has been tackled just yet.

This PR is already too big as it is and, for that reason, we decided to break up the remaining work into smaller tickets to have smaller and more manageable units of work.

You can see them here
We also made sure, where possible, to tie the TODOs in the code with the related tickets.

packages/api/src/pins.js

packages/db/index.js

packages/api/src/utils/pin.js

packages/api/test/mocks/pgrest/patch_pa_pin_request.js

vasco-santos · 2022-01-12T11:04:45Z

packages/db/db-client-types.ts

-  cid: definitions['pa_pin_request']['requested_cid'],
+  sourceCid: definitions['psa_pin_request']['source_cid'],
+  contentCid: definitions['upload']['content_cid'],
+  dagSize?: definitions['content']['dag_size'],


Will we be able to get this at the PinRequest creation timing? From the API Spec it seems like we won't? https://ipfs.github.io/pinning-services-api-spec/#tag/pins/paths/~1pins/post

I agree, I don't think we will but, honestly, we haven't dug into it just yet.
We have an issue to look into it more closely.
Can I reserve to give you a more accurate answer when we start working on it?

No we won't have this and can't get it from a worker. It will have to come from dagcargo after Cluster receives the data.

packages/api/src/utils/pin.js

vasco-santos

LGTM

alanshaw · 2022-01-13T11:10:51Z

packages/api/src/pins.js

-    // status instead
-  }
+  // TODO after some time if there are no pins we should give up and return a failed
+  // status instead


Seems that is what we do now, straight away. Maybe this can be removed?

I guess this relates to the fact that it'd be nice to have some kind of background task to check after a given defined threshold (an hour, a day, a week I don't know) to tell the cluster to stop trying to pin the cid (I know you have priority queues now but I still feel it should be good to programmatically stop the cluster trying).
At the same time, we should update the DB and therefore the request status accordingly.

I don't think this is a super high priority but still worth tracking?
If you agree I can update the comment to be more verbose and tie it with a github issue.

alanshaw · 2022-01-13T11:16:12Z

packages/api/src/pins.js

@@ -106,7 +103,7 @@ export async function pinPost (request, env, ctx) {

  // Validate cid
  try {
-    normalizeCid(cid)
+    pinData.normalizedCid = normalizeCid(cid)


Personally I'd not augment this user provided data with anything but instead pull out the bits you want and combine them any derived/additional data in a different object.

You caught me, I was being lazy 😛. On it.

alanshaw · 2022-01-13T11:18:51Z

packages/api/src/pins.js

+  await env.cluster.pin(cid, {
+    name: pinName,
+    origins,
+    metadata: meta


We can't pass user provided metadata to cluster. Cluster is not multi-tenant so two users pinning the same CID will ovewrite the meta.

Really good catch, I'll update.

alanshaw · 2022-01-13T11:22:34Z

packages/api/src/pins.js

  }

-  // TODO: Backups. At the moment backups are related to uploads so
+  // TODO(https://github.com/web3-storage/web3.storage/issues/794)


I think we should remove this todo. This is not where the code for backups of pin requests will live.

alanshaw · 2022-01-13T11:39:30Z

packages/db/db-client-types.ts

-  cid: definitions['pa_pin_request']['requested_cid'],
+  sourceCid: definitions['psa_pin_request']['source_cid'],
+  contentCid: definitions['upload']['content_cid'],
+  dagSize?: definitions['content']['dag_size'],


No we won't have this and can't get it from a worker. It will have to come from dagcargo after Cluster receives the data.

alanshaw · 2022-01-13T11:44:18Z

packages/db/index.js

+        name: pinRequestData.name,
+        dag_size: pinRequestData.dagSize,
+        inserted_at: pinRequestData.created || now,
+        updated_at: pinRequestData.updated || now,


Do we need to generate and send these two fields? The DB has defaults.

Yeah, I agree, I was "annoyed" by this as well.

IIRC we decided to keep it consistent with the createUpload behavior.
We're calling a remote procedure here and we were not quite sure what the behavior would be with defaults (when it comes to PostgreSQL) so we assumed there was some issue with that given your createUpload implementation.

* feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * fix: fix token referemce * fix: merge conflict issue * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: use uuid for psaPinRequests ids * feat: set search_path to public for uuid function, use uuid as pk on pin_request * feat: reinstated pin_request and updated psa_pin_request * bug: resolve merge conflicts * chore: typos and linting * bug: pinrequestid type string * fix: types * fix: update code to use strings for psa request ids Co-authored-by: Paolo <paolo@potatolondon.com> * chore: linting Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Gary Homewood <gary@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international>

* feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * fix: fix token referemce * fix: merge conflict issue * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * feat: filter pins by status * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * fix: updates and fixes after merge * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * fix: requestedCid to sourceCid * chore: clean up fixtures * chore: refactor filter by status in the db package * chore: refactor pinning api to match new db api * chore: use chromium for tests * chore: remove console log * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: lint error Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Paolo <paolo@potatolondon.com> Co-authored-by: Paolo Chillari <flea89@users.noreply.github.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international>

* feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * chore: db change for allowlist * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * feat: wip add pinning allowlist checking to API * fix: fix token referemce * chore: fix test mocking * feat: add tests for pinning allowlist * fix: merge conflict issue * chore: fix tests after merge * chore: review amends * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * chore: simplified allowlist middleware * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * feat: use separate pinning auth table * fix: db user test * fix: correct db type * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: allowlist on user id instead of token * fix: allow pinning user for post * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * chore: remove stale mock * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * fix: db test dead code * chore: merge from pinning-apis, de-dupe tests * fix: skip status db test * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: code review * chore: spelling consistency * chore: review changes Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Paolo <paolo@potatolondon.com> Co-authored-by: Paolo Chillari <flea89@users.noreply.github.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international>

* feat: temporary api backdoor (#722) * fix: postgres set max parallel workers per gather to 4 (#725) * chore: release @web3-storage/db 3.1.0 (#700) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/api 4.3.0 (#727) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/website 1.8.0 (#710) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Issue 703 - Navigation Links the Nextjs way (#716) * Fixed navigation links and trying to make loading screen more consistent because its jarring and the wrong color * small housecleaning items, loading wasnnt taking full screen * style updates for loading spinner * add active indicator for active link * trying something different adding active classes and a slug element * missed a slug * wrap navbar logo in Link component * feat: issue 689 added new column and metadata for review (#729) * added new column and metadata for review * feat: add new column for availability and fix copy for pin status * fix: mispelled available (#731) * fix: remove backdoor routes (#737) * fix: endpoint URL construction (#734) * fix: do not prefer node.js builtins (#748) * fix!: client should not throw on 404 (#751) * chore: release @web3-storage/db 4.0.0 (#753) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: update db breaking change * chore: release @web3-storage/api 5.0.0 (#752) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release web3.storage 3.5.1 (#740) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: created a formatter abstraction for filesize to standardize iec binary units for all file size display props (#757) * fix: remove dagcargo materialized views (#735) Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> * fix: db delete key return value (#766) * fix: api using db instead of mocks for tests (#765) * fix: tolerant of failure for deals (#769) * chore: release @web3-storage/db 4.0.1 (#767) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/api 5.0.1 (#768) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: Multiple File upload and uniform drag and drop (#567) * feat: multiple file upload feat: drag and drop from account page * fix: missed a deprecated function * fix: updated to include a remove file option * small update, add formatter Co-authored-by: Daniel <daniel.ashcraft@ofashandfire.com> * chore: create tool package with ipfs-cluster docker-compose setup. * chore: persist db data locally * chore: add start/stop scripts for db * chore: add ipf cluster docker to repo * chore: add debug npm script * chore: move things around * chore: create cli and expose it * chore: use named volume and make sure is deleted using stop:clean * chore: update readme * chore: action PR feedback * chore: remove stale mock:pgrest * chore: remove console logging * chore: make standard happy * fix: delete ops should update updated ts (#774) * chore: release @web3-storage/db 4.0.2 (#777) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/api 5.0.2 (#776) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: add metadata to backup (#783) * fix: improve list tokens (#782) Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> * chore: release @web3-storage/db 4.0.3 (#787) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/api 5.0.3 (#785) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: backup unique constraint (#795) * fix: remove temporary dag size sum for pins (#824) * chore: release @web3-storage/api 5.0.4 (#825) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: react-scripts-v5 compatible issue. (#826) * fix: update package lock (#827) * chore: release web3.storage 3.5.2 (#828) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix scroll issue on desktop safari (#822) * fix scroll issue on desktop safari * dont update package lock or next env file Co-authored-by: Daniel <daniel.ashcraft@ofashandfire.com> * chore: update pgrest (#816) * fix: db endpoint to use heroku (#817) * feat: add list of known peers hosting content for web3.storage (#837) A list of known IPFS peers that are hosting content uploaded to NFT.Storage. YOU DO NOT NEED THIS LIST. All peers that provide content on IPFS are discoverable via the DHT. IPFS transfers content P2P from multiple sources including other peers that recently acquired the content. Note: this list may be incorrect, may change, or become out of date at any time without notice. * chore: release @web3-storage/db 4.0.4 (#796) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/api 5.0.5 (#829) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/website 1.9.0 (#730) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: only disallow delete if dag size is unknown (#839) * chore: added leslieoa to api wrangler config (#849) * fix: dag size for big dags with non pb root (#850) * fix: update deps in api and client (#855) * chore: release @web3-storage/api 5.0.6 (#854) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release web3.storage 3.5.3 (#856) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/website 1.9.1 (#853) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release @web3-storage/w3 2.4.2 (#857) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: api cluster add car explicitly (#858) * chore: release @web3-storage/api 5.0.7 (#859) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: use single sentry project (#869) * chore: release @web3-storage/api 5.0.8 (#870) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: update add to web3 action (#841) * chore: update licenses (#831) * chore: remove commented metrics for dag size sum in pins (#838) * feat: w3 name CLI (#878) Adds some simple CLI commands for managing w3 names. * chore: release @web3-storage/w3 2.5.0 (#880) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: use docker cluster for api tests (#847) * feat: pinning API implementation * feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * fix: fix token referemce * fix: merge conflict issue * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: use uuid for psaPinRequests ids * feat: set search_path to public for uuid function, use uuid as pk on pin_request * feat: reinstated pin_request and updated psa_pin_request * bug: resolve merge conflicts * chore: typos and linting * bug: pinrequestid type string * fix: types * fix: update code to use strings for psa request ids Co-authored-by: Paolo <paolo@potatolondon.com> * chore: linting Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Gary Homewood <gary@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international> * perf: update pin composite index and adds inserted at index to content (#882) * docs: add note about reserved Remote upload type (#896) In NFT.Storage pin requests are added to the upload table with type "Remote". In dagcargo, PSA pin requests from Web3.Storage are combined with uploads (as they are in NFT.Storage) and are artificially given a type "Remote". Hence specifically adding a "Remote" type here would be problematic. * fix: unlist deleted pin requests (#899) * feat: add origins to psa pin request (#897) * feat: add origins to psa pin request * chore: remove comment * chore: remove only from test * chore: add better name for test * feat: filter pins by status (#848) * feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * fix: fix token referemce * fix: merge conflict issue * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * feat: filter pins by status * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * fix: updates and fixes after merge * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * fix: requestedCid to sourceCid * chore: clean up fixtures * chore: refactor filter by status in the db package * chore: refactor pinning api to match new db api * chore: use chromium for tests * chore: remove console log * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: lint error Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Paolo <paolo@potatolondon.com> Co-authored-by: Paolo Chillari <flea89@users.noreply.github.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international> * fix: update name in pinning status filtering test * feat: pinning api allowlist (#705) * feat(pinning-api): add skeleton and validation for pinning apis * feat: add pinning endpoints * feat: add tests * feat: add validation for endpoints and refactor error messages * fix: validation bug * feat: add tests for get and delete endpoints * fix: test assertions * feat: add replace pin api endpoint * chore: rollback type changes for now Co-authored-by: Paolo <paolo@potatolondon.com> * feat(pinning-apis): work on db to support new pinning apis * chore: rename PinsUpsertInput to PinUpsertInput * chore: fix PinUpsertInput type * chore: use PinUpsertInput where required * chore(refactor types): refactor pinItem * chore(refactor types): Use location with other types * chore(refactor types): fix some type errors in db client * chore(refactor types): rename PinItemOutput to PinItemNormalized * chore(refactor types): Pin item should have an _id field * Rename PinItemOutput back * feat(pinning-api-db): create pinning table and update reset.sql * feat(pinning-api-db): create initial types * feat(pinning-api-db): create db client signatures * feat(pinning-api-db): updat types * feat(pinning-api-db): write first intial add pin spec * feat(pinning-api-db): first implementation of create and get pinRequest * feat(pinning-api-db): get pin data for request * feat(pinning-api-db): housekeeping * feat(pinning-api-db): get pin request tests * feat(pinning-api-db): housekeeping * feat: add types to db data types * feat(pinning-api-db): create content function * feat(pinning-api-db): remove duplicated type * feat(pinning-api-db): housekeeping * feat(pinning-api-db): update types * feat(pinning-api-db): update documentation * chore: db change for allowlist * Add endpoint and logic to our api service (#702) * feat(pinning-apis): get request endpoint work * chore: remove logging * chore: improve validation get /pin/requestId * chore: better integer validation * fix: requestId conditional * fix: remove extra bracket Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> * feat(pinning-apis): POST /pin endpoint * wip: create pin request * feat: add async task * chore: merge feature branch * feat: code improvements * chore: add todo * feat: add comments and some small fixes * fix: pass token id * fix: normalized cid vs source cid * fix: minor fix and tests updates * fix: update return of get user mock Co-authored-by: Paolo <paolo@potatolondon.com> * chore: make standard happier * feat: wip add pinning allowlist checking to API * fix: fix token referemce * chore: fix test mocking * feat: add tests for pinning allowlist * fix: merge conflict issue * chore: fix tests after merge * chore: review amends * feat : delete and replace pin requests endpoints * wip: delete pin request * feat: add db definitions * feat: wip replace pin endpoint * chore: update mocks * fix: do not list deleted requests * feat: add delete db tests * fix: tests * fix: improve validation * feat: tests * chore: update comments * fix: replace pin bugs and tests * fix: coerce to number using parseInt * chore: disable tests for now Co-authored-by: Paolo <paolo@potatolondon.com> * chore: simplified allowlist middleware * feat: GET /pins endpoint * feat: wip list pin requests * feat: list pinning requests * chore: renaming test descriptions * chore: filter for list pins * chore: fixing tests * chore: list pins tests * feat: db and api tests for list pins * chore: reorder list test * fix: correct count in list response * fix: avoid double query on list * feat: PR feedback * feat: add todo for future improv * fix: typos, use new URL in test, improve Date test * feat: don't skip test * fix: update tests and more fixes * fix: take back the todo Co-authored-by: Gary Homewood <gary@potatolondon.com> * feat: use separate pinning auth table * fix: db user test * fix: correct db type * Refactor Pin APIs and PR feedback (#810) chore: pinning apis refactoring and feedback * feat: update sql and db client logic * feat: update tests and minor fixes * feat: more updates/fixes to db package * feat: refactor pin creation flow and refactor car upload as well * feat: pinning, fix tests and add more * fix: rename table, functions and types * chore: PR feedback * fix: rename types * chore: rename requestedCid to sourceCid * fix: delete should not return a body and status should be 202 * chore: add some documentation to waitOkPins * chore: delete stale mock * fix: allowlist on user id instead of token * fix: allow pinning user for post * fix: do not passa meta to cluster * chore: remove comment * chore: refactor createPin * chore: linting * chore: remove stale mock * Get request id by user token (#863) * fix: get pin req ids by user token * fix: update tests * fix: rest api types * fix: update function params * fix: type name * feat: add test * fix: tests * fix: merge conflict * fix: merge * fix: rename authToken id * fix: db test dead code * chore: merge from pinning-apis, de-dupe tests * fix: skip status db test * Add metadata to API (#881) * feat: add metadata to psa pin req * feat: add metadata to api * feat: add metadata tests * chore: feedback * feat: added pinning service request issue mailto link/github button (#879) * feat: added pinning service request issue mailto link/github button * chore: new line * Fix test * fix: update comment to reflect changes * fix: code review * chore: spelling consistency * chore: review changes Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Paolo <paolo@potatolondon.com> Co-authored-by: Paolo Chillari <flea89@users.noreply.github.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international> * chore: improve release ci (#907) * fix: remove resize observer, use css for responsive menu (#778) remove resize observer, use css instead * fix: return right psa status in APIs Co-authored-by: Vasco Santos <santos.vasco10@gmail.com> * refactor: esm in worker (#902) Converts the built worker JS to ESM. Uses miniflare for testing. This enables using durable objects in the worker so that we can have websockets for w3name. When we get websockets, I can write the [IPNS publisher to listen for updates and publish to the DHT](#662). I realised it was going to be a PITA to get Cloudflare expected ESM format (export a default object with a fetch function) to work with regular workers in our tests...I ended up adding miniflare to the tests. refs #659 reolves #852 * fix: sentry version cannot contain slash (#924) Fixes: ``` Error: Command failed: /github/workspace/node_modules/@sentry/cli/sentry-cli releases new @web3-storage/api@5.0.8-dev+c1f7a1b error: Invalid value for '<VERSION>': Invalid release version. Slashes and certain whitespace characters are not permitte ``` * fix: update package.json main entry * fix: check if unpinned then downgrade to v0 (#919) * fix: check if unpinned then denormalize to v0 * fix: renamed module * fix: added cid module to cron package * fix: correct paths/typo * fix: denormaize contentCid not serial pk (id) * fix: pr bugfixes and change requests * chore: denormalize to downgrade * fix: attempt to downgrade cid * fix: move attempt to downgrade cid to cid util * chore: remove unused util from api * fix: error path * fix: check if unpinned * fix: unnecessary call to getpinstatus, push to resync pins * fix: psa pin request status * fix: limit the psa request listing and return right count * fix: updated mailto link copy (#939) * fix: bind normalizedCid instead of function (#941) * fix: bind normalizedCid instead of function (#942) * feat: websockets support for w3name (#932) This PR adds support for websockets to w3name. Establish a websocket connection to `wss://api.web3.storage/name/:key/watch` and receive JSON encoded messages like: `{ key: string, value: string, record: string }` when updates to the key are published. * [x] Refactor to ESM to allow usage of "Durable Objects" #902 * [x] Configuration to enable `NameRoom` as a durable object * [ ] Client API (will do in separate PR) supersedes #653 Related to #659 * fix: include meta for replace pin (#935) * fix: include meta for create pin * chore: include valid origins on pin replace * fix: don't send meta to cluster * chore(main): release api 5.1.0 (#909) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: durable objects config (#949) I think the top level durable objects config does not work when publishing for reals. * fix: user and auth token type declarations (#948) * fix: add pre-bundled ESM build to package exports (#930) * fix: add pre-bundled ESM build to package exports * chore: format JSON * chore: remove added whitespace * chore: ok all of it fml Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> * fix: add initial migration (#951) * chore(main): release web3.storage 3.5.4 (#952) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(main): release api 5.1.1 (#950) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: size for single block raw node (#958) * chore(main): release api 5.1.2 (#959) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: db client do not throw error when no upload found (#885) * chore: remove migration tracking table (#832) * chore(main): release api 5.1.3 (#964) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: schema updates for admin site (#947) Co-authored-by: Joe Spencer <joe.spencer@discounttire.com> * Adding user_tag table to facilitate user restricted application features. (#955) * pinning allowlist and user account storage limits can be managed by this single table without the need for one-off tables e.g. pinning_authorization. * this allows the admin.storage site to easily manage tags. Co-authored-by: Joe Spencer <joe.spencer@discounttire.com> * fix: invalid CAR errors (#977) * chore(main): release api 5.1.4 (#978) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Manually resolve collisions between main and new brand wip * chore: Pinning and updating dependancies Co-authored-by: Vasco Santos <santos.vasco10@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Ashcraft <daniel.ashcraft@ofashandfire.com> Co-authored-by: Alan Shaw <alan.shaw@protocol.ai> Co-authored-by: Zé Bateira <jose.bateira@protonmail.com> Co-authored-by: Paolo Chillari <flea89@users.noreply.github.com> Co-authored-by: Victor <nftvictor@gmail.com> Co-authored-by: Chris Anderson <jchris@gmail.com> Co-authored-by: Leslie Owusu-Appiah <leslie@localhost.international> Co-authored-by: Alexandra Stoica <ralexandrastoica@gmail.com> Co-authored-by: Alexandra Stoica <alexandra.stoica@potatolondon.com> Co-authored-by: Gary Homewood <gary@potatolondon.com> Co-authored-by: Paolo <paolo@potatolondon.com> Co-authored-by: Hugo Dias <hugomrdias@gmail.com> Co-authored-by: Yusef Napora <yusef@protocol.ai> Co-authored-by: trigramdev9 <98334141+trigramdev9@users.noreply.github.com> Co-authored-by: Joe Spencer <joe.spencer@discounttire.com> Co-authored-by: Michael Phan <michael.d.phan@gmail.com>

flea89 added 5 commits December 14, 2021 14:54

feat: update sql and db client logic

c891d1a

feat: update tests and minor fixes

2d39d2c

feat: more updates/fixes to db package

285ddea

feat: refactor pin creation flow and refactor car upload as well

19b579d

Merge branch 'feat/pinning-apis' into feat/refactor-add-pin

c2284c9

flea89 marked this pull request as draft December 16, 2021 18:10

flea89 marked this pull request as ready for review December 16, 2021 21:03

flea89 marked this pull request as draft December 16, 2021 21:04

flea89 added 2 commits December 17, 2021 10:54

feat: pinning, fix tests and add more

c929456

fix: rename table, functions and types

079d31f

flea89 mentioned this pull request Dec 17, 2021

Pinning APIs #726

Merged

flea89 added 3 commits December 17, 2021 12:52

chore: PR feedback

ee7a8b6

fix: rename types

398000c

chore: rename requestedCid to sourceCid

c83613a

flea89 changed the title ~~Refactor Pin APIs~~ Refactor Pin APIs and PR feedback Dec 17, 2021

fix: delete should not return a body and status should be 202

513201c

mbommerez linked an issue Dec 17, 2021 that may be closed by this pull request

Refactor - Pin Request creation #786

Closed

GaryHomewood reviewed Jan 11, 2022

View reviewed changes

packages/api/src/pins.js Show resolved Hide resolved

packages/db/index.js Show resolved Hide resolved

packages/api/src/utils/pin.js Show resolved Hide resolved

GaryHomewood reviewed Jan 11, 2022

View reviewed changes

packages/api/src/utils/pin.js Show resolved Hide resolved

chore: add some documentation to waitOkPins

39a15c7

flea89 marked this pull request as ready for review January 11, 2022 16:57

flea89 requested review from alanshaw and vasco-santos January 11, 2022 16:57

vasco-santos reviewed Jan 12, 2022

View reviewed changes

chore: delete stale mock

2e695d0

flea89 mentioned this pull request Jan 13, 2022

Improvement - Upsert list of pins instead of looping #862

Closed

flea89 requested a review from vasco-santos January 13, 2022 09:58

vasco-santos approved these changes Jan 13, 2022

View reviewed changes

flea89 merged commit ae65ae3 into feat/pinning-apis Jan 13, 2022

flea89 deleted the feat/refactor-add-pin branch January 13, 2022 11:04

alanshaw reviewed Jan 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Pin APIs and PR feedback #810

Refactor Pin APIs and PR feedback #810

flea89 commented Dec 16, 2021 •

edited

Loading

vasco-santos Jan 12, 2022

flea89 Jan 13, 2022

alanshaw Jan 13, 2022

vasco-santos left a comment

alanshaw Jan 13, 2022

flea89 Jan 13, 2022

flea89 Jan 21, 2022

alanshaw Jan 13, 2022

flea89 Jan 14, 2022

alanshaw Jan 13, 2022

flea89 Jan 13, 2022

alanshaw Jan 13, 2022

flea89 Jan 13, 2022

alanshaw Jan 13, 2022

alanshaw Jan 13, 2022

flea89 Jan 13, 2022

Refactor Pin APIs and PR feedback #810

Refactor Pin APIs and PR feedback #810

Conversation

flea89 commented Dec 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vasco-santos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flea89 commented Dec 16, 2021 •

edited

Loading