CORS errors fixed in WebKit and Gecko based browsers

web3 · Mar 25, 2019 · 9116b45 · 9116b45
1 parent 169fceb
commit 9116b45
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/packages/web3-providers/package-lock.json b/packages/web3-providers/package-lock.json
diff --git a/packages/web3-providers/src/factories/ProvidersModuleFactory.js b/packages/web3-providers/src/factories/ProvidersModuleFactory.js
@@ -86,8 +86,15 @@ export default class ProvidersModuleFactory {
      * @returns {XMLHttpRequest}
      */
     createXMLHttpRequest(host, timeout = 0, headers, agent, withCredentials) {
-        const request = new XHR();
-        request.nodejsSet(agent);
+        let request;
+
+        // runtime is of type node
+        if (typeof process !== 'undefined' && process.versions != null && process.versions.node != null) {
+            request = new XHR();
+            request.nodejsSet(agent);
+        } else {
+            request = new XMLHttpRequest();
+        }
 
         request.open('POST', host, true);
         request.setRequestHeader('Content-Type', 'application/json');

diff --git a/packages/web3-providers/tests/src/providers/HttpProviderTest.js b/packages/web3-providers/tests/src/providers/HttpProviderTest.js
@@ -52,7 +52,7 @@ describe('HttpProviderTest', () => {
             {headers: [], timeout: 1, keepAlive: true, withCredentials: true},
             providersModuleFactoryMock
         );
-        
+
         expect(httpProvider.host).toEqual('http');
 
         expect(httpProvider.headers).toEqual([]);