Merge pull request #2248 from ethereum/issue/2246

Response handling of GetTransactionReceiptMethod fixed and test updated
web3 · Jan 28, 2019 · b9b9304 · b9b9304
2 parents af15afa + 1052f10
commit b9b9304
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/web3-core-method/src/methods/transaction/GetTransactionReceiptMethod.js b/packages/web3-core-method/src/methods/transaction/GetTransactionReceiptMethod.js
@@ -38,11 +38,15 @@ export default class GetTransactionReceiptMethod extends AbstractCallMethod {
      *
      * @method afterExecution
      *
-     * @param {Object} response
+     * @param {Object|null} response
      *
-     * @returns {Object}
+     * @returns {Object|null}
      */
     afterExecution(response) {
-        return this.formatters.outputTransactionFormatter(response);
+        if (response !== null) {
+            return this.formatters.outputTransactionFormatter(response);
+        }
+
+        return response;
     }
 }
diff --git a/packages/web3-core-method/tests/src/methods/transaction/GetTransactionReceiptMethodTest.js b/packages/web3-core-method/tests/src/methods/transaction/GetTransactionReceiptMethodTest.js
@@ -34,4 +34,8 @@ describe('GetTransactionReceiptMethodTest', () => {
 
         expect(formatters.outputTransactionFormatter).toHaveBeenCalledWith({});
     });
+
+    it('afterExecution should return null', () => {
+        expect(method.afterExecution(null)).toEqual(null);
+    });
 });