Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings for all packages #2085

Closed
4 tasks done
nivida opened this issue Nov 30, 2018 · 30 comments
Closed
4 tasks done

Add TypeScript typings for all packages #2085

nivida opened this issue Nov 30, 2018 · 30 comments

Comments

@nivida
Copy link
Contributor

nivida commented Nov 30, 2018

This is a gitcoin bounty.

ToDo:

  • Add type definitions for all modules
  • Add dtslint tests for all modules
  • Add typings to PR template check list
  • See if there's a coverage tool for dtslint tests
@nivida nivida added the bounty label Nov 30, 2018
@joshstevens19
Copy link
Contributor

joshstevens19 commented Dec 1, 2018

Already on this as we know (as I was the one who suggested this change). Will wait for bounty to be created but will carry on with the tasks 😃

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 600.0 DAI (600.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Foundation fund.

@gitcoinbot
Copy link

gitcoinbot commented Dec 4, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 months ago.
Please review their action plans below:

1) joshstevens19 has been approved to start work.

Hey i was the one who initially thought of this issue and suggested it to Sam.

I have already done 2 PR for 2 packages and think i would be the correct suited for this job!

Learn more on the Gitcoin Issue Details page.

2) huanzhang89 has applied to start work (Funders only: approve worker | reject worker).

Will be helping Josh on this. First time using gitcoin, just trying this out :)

Learn more on the Gitcoin Issue Details page.

3) samthomson has applied to start work (Funders only: approve worker | reject worker).

I have experience working with TypeScript including projects which moved from JS to Typescript. Would be happy to help out with this.

Learn more on the Gitcoin Issue Details page.

@spm32
Copy link

spm32 commented Dec 5, 2018

Just approved you @joshstevens19 glad to have you helping out :)

@joshstevens19
Copy link
Contributor

Cheers Scott 👍

@gitcoinbot
Copy link

@joshstevens19 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@joshstevens19
Copy link
Contributor

joshstevens19 commented Dec 8, 2018

Yes I have already done 3 PRs which have been merged for 3 packages, will be doing the other ones when I get a second! 😁

@joshstevens19
Copy link
Contributor

PR number 1 - #2073

@joshstevens19
Copy link
Contributor

PR number 2 - #2084

@joshstevens19
Copy link
Contributor

PR number 3 - #2090

@joshstevens19
Copy link
Contributor

PR number 4 - #2112

@joshstevens19
Copy link
Contributor

PR number 5 - #2096

@joshstevens19
Copy link
Contributor

PR number 6 - #2114

@joshstevens19
Copy link
Contributor

joshstevens19 commented Dec 11, 2018

PR number 7 - #2118

@joshstevens19
Copy link
Contributor

joshstevens19 commented Dec 11, 2018

PR number 8 - #2119

@joshstevens19
Copy link
Contributor

PR number 9 - #2121

@joshstevens19
Copy link
Contributor

PR number 10 - #2122

@joshstevens19
Copy link
Contributor

PR number 11 - #2123

@joshstevens19
Copy link
Contributor

PR number 12 - #2125

@joshstevens19
Copy link
Contributor

PR number 13 - #2128

@joshstevens19
Copy link
Contributor

PR number 14 - #2130

@joshstevens19
Copy link
Contributor

Final PR #2133

@nivida
Copy link
Contributor Author

nivida commented Dec 18, 2018

@ceresstation This bounty is now done :)
Thanks to @joshstevens19 for this awesome work!

@joshstevens19
Copy link
Contributor

@ceresstation I have submitted the work on gitcoin 👍

@joshstevens19
Copy link
Contributor

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 600.0 DAI (600.0 USD @ $1.0/DAI) has been submitted by:

  1. @joshstevens19

@ceresstation please take a look at the submitted work:


@joshstevens19
Copy link
Contributor

@ceresstation hey when will the gitcoin bounty be paid out ?

@spm32
Copy link

spm32 commented Jan 8, 2019

Hey @joshstevens19 sorry for the delay here, paying you out now :)

@gitcoinbot
Copy link

Javascript Master Scriber ⚡️ A *Javascript Master Scriber* Kudos has been sent to @joshstevens19 for this issue from @ceresstation. ⚡️

Nice work @joshstevens19!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 600.0 DAI (600.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @joshstevens19.

@nivida nivida closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants