Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web3-eth-accounts/dist/web3-eth-accounts wording error #2469

Closed
Senshii opened this issue Mar 7, 2019 · 2 comments
Closed

web3-eth-accounts/dist/web3-eth-accounts wording error #2469

Senshii opened this issue Mar 7, 2019 · 2 comments
Labels
Bug Addressing a bug

Comments

@Senshii
Copy link

Senshii commented Mar 7, 2019 •
edited
Loading

Hello,

It seems like there is a wording error with 'transactionSinger' instead of 'transactionSigner' at web3-eth-accounts/dist/web3-eth-accounts.cjs.js:77:70)

Versions

  • web3.js: web3@1.0.0-beta.47 and web3@1.0.0-beta.48
  • nodejs: v10.14.2

Thank you,
@Senshii Senshii changed the title Wallet.encrypt() error web3-eth-accounts/dist/web3-eth-accounts wording error Mar 7, 2019
@nivida
Copy link
Contributor

nivida commented Mar 7, 2019

Will be fixed with this PR: #2466

@nivida nivida added the Bug Addressing a bug label Mar 7, 2019
@nivida
Copy link
Contributor

nivida commented Mar 15, 2019

The wording error got fixed with PR #2466.

@nivida nivida closed this as completed Mar 15, 2019
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nivida @Senshii