Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction confirmation workflow improvements #2466

Merged
merged 91 commits into from
Mar 14, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 6, 2019

Description

This PR will fix the confirmation workflow which does not correctly return the confirmations count over the HttpProvider. I will also do some other improvements regarding the transaction method handling.

Fixes #2418

Type of change

  • Bug fix
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Mar 6, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+4.0%) to 98.505% when pulling 346f159 on enhacement/transaction-confirmations into 5023c45 on 1.0.

@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage increased (+4.0%) to 98.505% when pulling ecef7a8 on enhacement/transaction-confirmations into 5023c45 on 1.0.

@nivida nivida merged commit cd32de2 into 1.0 Mar 14, 2019
@nivida
Copy link
Contributor Author

nivida commented Mar 14, 2019

Merged with a failed build because dtslint is just failing on travis and it works locally with the NodeJS versions we have configured on travis.

@nivida nivida deleted the enhacement/transaction-confirmations branch March 15, 2019 09:57
@nivida nivida removed the In Progress Currently being worked on label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PromiEvent event listener on confirmations not returning correct confirmation information
4 participants