-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction confirmation workflow improvements #2466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore-method module clean up and core-promievent deleted and moved to the Eth module because it's just used there
…ore-method module clean up and core-promievent deleted and moved to the Eth module because it's just used there
…vement of the MethodModuleFactory
…cause I had to update the dependency handling anyways in most modules
…he tc39 observable standard
nivida
added
Bug
Addressing a bug
Enhancement
Includes improvements or optimizations
In Progress
Currently being worked on
labels
Mar 6, 2019
… and simple core-method module
…ty changed to a getArguments and setArguments method because of a name conflict
…d to 'npm install' because node version 9 does not support it.
Merged with a failed build because |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix the confirmation workflow which does not correctly return the confirmations count over the
HttpProvider
. I will also do some other improvements regarding the transaction method handling.Fixes #2418
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct