Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly list dependencies in subpackages #2667

Closed
levino opened this issue Apr 11, 2019 · 6 comments · Fixed by #2788
Closed

Correctly list dependencies in subpackages #2667

levino opened this issue Apr 11, 2019 · 6 comments · Fixed by #2788
Labels
Types Incorrect or missing types

Comments

@levino
Copy link
Contributor

levino commented Apr 11, 2019

https://github.com/ethereum/web3.js/blob/441c309d3304ffbc36fca4ef483adf314b5f4801/packages/web3-core-method/types/index.d.ts#L20-L22

This makes web3-utils, web3-core and web3-core-helpers dependencies of web3-core-method.

I guess the same issue exists in many other places.

@levino
Copy link
Contributor Author

levino commented Apr 11, 2019

Another solution could be to somehow flatten the type definitions. That would be a nightmare because one would have different types all over the place.

@nivida
Copy link
Contributor

nivida commented Apr 14, 2019

I would like to fix this with the simplification of the folder structure to something like this:

web3/
  core/
    method/
  eth/
...

@nivida nivida added Discussion Enhancement Includes improvements or optimizations labels Apr 14, 2019
@levino
Copy link
Contributor Author

levino commented Apr 14, 2019

As in "stop shipping individual packages"?

@nivida
Copy link
Contributor

nivida commented Apr 15, 2019

Yes @levino

@levino
Copy link
Contributor Author

levino commented May 7, 2019

This is a big fat bug. You are using code but not adding it as a dep.

@nivida
Copy link
Contributor

nivida commented May 7, 2019

Will add the missing dependencies for the types on the next release.

@nivida nivida added Types Incorrect or missing types and removed Discussion Enhancement Includes improvements or optimizations labels May 7, 2019
@nivida nivida mentioned this issue May 7, 2019
12 tasks
@nivida nivida mentioned this issue May 9, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants