Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies updated #2788

Merged
merged 2 commits into from
May 7, 2019
Merged

Dependencies updated #2788

merged 2 commits into from
May 7, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented May 7, 2019 •
edited
Loading

Description

Fixes #2667

Type of change

  • Types

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added In Progress Currently being worked on Types Incorrect or missing types labels May 7, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.979% when pulling 24a20ab on issue/2667 into 5eab09d on 1.0.

@nivida nivida removed the In Progress Currently being worked on label May 7, 2019
@nivida nivida merged commit 107e143 into 1.0 May 7, 2019
@nivida nivida deleted the issue/2667 branch May 7, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly list dependencies in subpackages
2 participants
@nivida @coveralls