Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched interface #4871

Closed
tdelabro opened this issue Mar 19, 2022 · 6 comments · Fixed by #5083
Closed

Mismatched interface #4871

tdelabro opened this issue Mar 19, 2022 · 6 comments · Fixed by #5083
Labels
1.x 1.0 related issues

Comments

@tdelabro
Copy link

https://github.com/ChainSafe/web3.js/blob/505b833b0952b231ef2728c752d6667c9ed0f858/packages/web3-eth/types/index.d.ts#L404

The actual key described in the protocol is transactionsRoot with a s.
See: https://eth.wiki/json-rpc/API#eth_getlogs

@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 21, 2022
@nazarhussain
Copy link
Contributor

@tdelabro Thanks for reaching to us with the issue. We will try to get it fixed as soon we have some bandwidth.

@tdelabro
Copy link
Author

If you agree on this change and that it require nothing more than changing this file, I can do a pull request myself

@OscBacon
Copy link

Hey, any updates on this? I can't see a relevant pull request, and it would make things easier than having to redefine an interface to work with web3js

@nikoulai
Copy link
Contributor

Hi, @OscBacon Thanks for reaching out to us. Currently, all our resources are focused on 4.x rewrite. Feel free to open a PR addressing this.

@OscBacon
Copy link

Sure!

@OscBacon
Copy link

OscBacon commented Jun 5, 2022

Hey, so the PR is ready, and has one approval, but it's missing another approval to get merged. Let's aim to wrap this up soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants