-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatched interface #4871
Comments
@tdelabro Thanks for reaching to us with the issue. We will try to get it fixed as soon we have some bandwidth. |
If you agree on this change and that it require nothing more than changing this file, I can do a pull request myself |
Hey, any updates on this? I can't see a relevant pull request, and it would make things easier than having to redefine an interface to work with web3js |
Hi, @OscBacon Thanks for reaching out to us. Currently, all our resources are focused on 4.x rewrite. Feel free to open a PR addressing this. |
Sure! |
Hey, so the PR is ready, and has one approval, but it's missing another approval to get merged. Let's aim to wrap this up soon! |
https://github.com/ChainSafe/web3.js/blob/505b833b0952b231ef2728c752d6667c9ed0f858/packages/web3-eth/types/index.d.ts#L404
The actual key described in the protocol is
transactionsRoot
with as
.See: https://eth.wiki/json-rpc/API#eth_getlogs
The text was updated successfully, but these errors were encountered: