Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transactionRoot -> transactionsRoot in BlockHeader #5083

Merged
merged 6 commits into from
Jul 4, 2022
Merged

Fix transactionRoot -> transactionsRoot in BlockHeader #5083

merged 6 commits into from
Jul 4, 2022

Conversation

OscBacon
Copy link

@OscBacon OscBacon commented May 26, 2022 •
edited
Loading

Description

Fix transactionRoot -> transactionsRoot in BlockHeader

Fixes #4871

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Note: only changing the interface

@OscBacon
Copy link
Author

@nikoulai εδώ είναι!

@OscBacon
Copy link
Author

Also note, I ran a quick grep -r and there's no reference in the repo to transaction(s)Root :)

vcheeney
vcheeney approved these changes May 31, 2022
View reviewed changes
Copy link

@vcheeney vcheeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encountered the same problem. Would have made the same change. 👍

@vcheeney
Copy link

@OscBacon I encountered the same problem. Thanks for creating this PR. Would really like this merged 👍

@OscBacon
Copy link
Author

No problem @vcheeney !
@nikoulai, could you please give the second thumbs up?

@jdevcs jdevcs mentioned this pull request Jun 9, 2022
Closed
14 tasks
@jdevcs jdevcs added the 1.x 1.0 related issues label Jun 9, 2022
@OscBacon OscBacon force-pushed the fix/transactionRoot branch from d1ac38c to a6fa821 Compare June 10, 2022 05:42
nazarhussain
nazarhussain requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add entry to CHANGELOG.md

@nazarhussain nazarhussain added Types Incorrect or missing types Review Needed Maintainer(s) need to review labels Jun 22, 2022
@coveralls
Copy link

coveralls commented Jun 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2608297579

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.004%
Totals Coverage Status
Change from base Build 2596319045: 0.0%
Covered Lines: 3388
Relevant Lines: 4430
💛 - Coveralls

avkos
avkos approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments to CHANGELOG.md

@OscBacon
Copy link
Author

@avkos ? where in the file? and with or without a version tag?

@nikoulai
Copy link
Contributor

@OscBacon Hi,
you will find CHANGELOG.md at the root of the repo. You can mention your change under 1.7.5 with a reference to the issue. Take as example the other comments.

@OscBacon
Copy link
Author

@nikoulai Done! Please merge whenever you can!

@nikoulai nikoulai requested a review from nazarhussain June 29, 2022 08:43
@nikoulai
Copy link
Contributor

@OscBacon Looks good.

Have to wait for changes to be approved.
cc @nazarhussain

@OscBacon OscBacon force-pushed the fix/transactionRoot branch from 940da14 to 3867cf8 Compare June 30, 2022 22:08
@OscBacon
Copy link
Author

Hey @nazarhussain, @jdevcs, @nikoulai: could one of you authorize the merge now please? :)

@nazarhussain nazarhussain added Future Release For future release. and removed Review Needed Maintainer(s) need to review labels Jul 1, 2022
@jdevcs jdevcs changed the base branch from 1.x to junaid/txrootfix July 4, 2022 13:00
@jdevcs jdevcs merged commit 4b6e9ec into web3:junaid/txrootfix Jul 4, 2022
@jdevcs jdevcs mentioned this pull request Jul 4, 2022
Merged
16 tasks
jdevcs added a commit that referenced this pull request Jul 4, 2022
@jdevcs @nikoulai @OscBacon
Fix transactionRoot -> transactionsRoot in BlockHeader (#5083) (#5197)
2a1308f 
* Fix transactionRoot -> transactionsRoot in BlockHeader

* Update CHANGELOG.md

Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Oscar Baracos <oscar.baracos@gmail.com>
@jdevcs
Copy link
Contributor

jdevcs commented Jul 4, 2022

Merged via #5197

@jdevcs jdevcs mentioned this pull request Jul 15, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@vcheeney vcheeney vcheeney approved these changes

@nikoulai nikoulai nikoulai approved these changes

@avkos avkos avkos approved these changes

@nazarhussain nazarhussain nazarhussain approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
1.x 1.0 related issues Future Release For future release. Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatched interface
7 participants
@OscBacon @vcheeney @coveralls @nikoulai @jdevcs @nazarhussain @avkos