Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] types Web3BaseProvider for EIP1193Provider has event wrong type in web3-types #5939

Closed
1 task done
BeroBurny opened this issue Mar 21, 2023 · 0 comments
Closed
1 task done
Assignees
Labels
4.x 4.0 related Bug Addressing a bug Estimate

Comments

@BeroBurny
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

public abstract on(
type: 'disconnect',
callback: Web3ProviderEventCallback<ProviderRpcError>,
): void;
public abstract on<T = JsonRpcResult>(
type: 'message' | string,
callback: Web3ProviderEventCallback<T>,
): void;
public abstract on(
type: 'connect' | 'chainChanged',
callback: Web3ProviderEventCallback<ProviderConnectInfo>,
): void;
public abstract on(
type: 'accountsChanged',
callback: Web3ProviderEventCallback<{
readonly accounts: string[];
}>,
): void;

Expected Behavior

to be alignment with the specification
https://eips.ethereum.org/EIPS/eip-1193#appendix-i-consumer-facing-api-documentation

Steps to Reproduce

n/a

Web3.js Version

4.x

Environment

n/a

Anything Else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug Estimate
Projects
None yet
Development

No branches or pull requests

5 participants