-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nikos/5939/eip1193 provider callback types #5971
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5971 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 156 156
Lines 7408 7408
Branches 2006 2006
=======================================
Hits 6358 6358
Misses 1050 1050
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ithub.com/web3/web3.js into nikos/5939/EIP1193Provider-callback-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, there is tiny stuff. If you can address them, before merging.
): void; | ||
public removeListener<T = JsonRpcResult>( | ||
type: string, | ||
listener: Web3Eip1193ProviderEventCallback<any> | Web3ProviderEventCallback<T>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listener: Web3Eip1193ProviderEventCallback<any> | Web3ProviderEventCallback<T>, | |
listener: Web3Eip1193ProviderEventCallback<unknown> | Web3ProviderEventCallback<T>, |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except few changes required. ( also update change log ) Thanks @nikoulai
Signed-off-by: Nikos Iliakis <nikoulai94@hotmail.com>
Description
fixes events' callback types for eip1193 providers
closes #5939
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.