Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'disconnect' in Eip1193 provider must emit ProviderRpcError #6003

Closed
2 tasks done
nikoulai opened this issue Apr 11, 2023 · 0 comments · Fixed by #6230
Closed
2 tasks done

'disconnect' in Eip1193 provider must emit ProviderRpcError #6003

nikoulai opened this issue Apr 11, 2023 · 0 comments · Fixed by #6230
Assignees
@Muhammad-Altabba
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@nikoulai
Copy link
Contributor

This is not a Bug Report, Feature Request, or related to Documentation

  • I have searched the existing issues

Is there an existing issue for this?

  • I have searched the existing issues

What's up?

In packages/web3-utils/src/web3_eip1193_provider.ts _onDisconnect emits an object with code and data.

The EIP states that it should be of type ProviderRpcError

Examples/References

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Muhammad-Altabba Muhammad-Altabba

Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: 'disconnect' in Eip1193 provider must emit ProviderRpcError web3/web3.js
3 participants
@nikoulai @Muhammad-Altabba @mconnelly8