fix bug when 2+ events are returned in logs subscription

[ewingrj]

If 2 or more of the same event type are logged in a single transaction,
the eth_subscription result will contain multiple logs.

[ewingrj]

I'm wondering if it might be better for output to always be an array. Otherwise, clients will need to issue an array check in the subscription handler if there is a possibility for multiple events.

I can update the PR if you agree.

[frozeman]

The subscription notification return should only return objects, i discussed that a long time ago with @bas-vk and assumed it is fixed.
If there are multiple logs, it should fire multiple notifications, one per log.

[frozeman]

Supposedly geth will only return one log at a time, did you experience multiple logs, and if so with which version of geth? @perissology

[coveralls]

Coverage decreased (-0.03%) to 85.182% when pulling 8fe0d33 on perissology:subscription_result_array into f5bc2ba on ethereum:1.0.

[bas-vk]

This was fixed more than a year ago.
If you still have this issue with a recent version of geth it would help if you could provide an example.

[coveralls]

Coverage decreased (-0.2%) to 85.135% when pulling 7e469ff on perissology:subscription_result_array into f3fc88a on ethereum:1.0.

[ewingrj]

ah sorry, I was actually using parity parity_subscription v1.7.0-beta-5f2cabd-20170727.

not sure about geths eth_subscription

[ewingrj]

so is this a parity bug then?

[ewingrj]

@frozeman ^

[frozeman]

They will fix that.