Feature/exact version dependencies #1130
Conversation
…encies to exact released versions on all the web3-* packages.
Fixed the `gulp version` task so that it updates all the necessary files, including `.versions` Changed the `release` npm script to update all versions (via lerna), *then* rebuild the dist files, then do the full `lerna publish` step.
gulpfile.js
Outdated
| './package.json', | ||
| './bower.json', | ||
| './package.js', | ||
| './.versions' |
There was a problem hiding this comment.
This will be generated by meteor and can’t be modified directly.
package.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| "postinstall": "lerna bootstrap", | |||
| "build": "gulp", | |||
| "build-all": "gulp all", | |||
| "release": "lerna bootstrap; gulp; lerna publish --skip-git; gulp version;", | |||
| "release": "lerna bootstrap; lerna publish --yes --cd-version prerelease --exact --skip-npm --skip-git; gulp version; gulp; git checkout lerna.json; lerna publish --cd-version prerelease --exact --skip-git", | |||
There was a problem hiding this comment.
This one I don’t understand.if you call publish twice it will increase by two versions. Seems the only thing you had todo is add —exact
We can’t hardcode prelrelease, as in the future I will also release other versions.
For what is the git checkout lerna.json?
This needs to be simplified, currently it will probably create more issues than it solves.
There was a problem hiding this comment.
OK, now I'm confused as well. I added the complexity as a way to work around an issue I was seeing where the built web3.min.js contained out-of-date version numbers for some packages. The addition of --skip-npm and the git checkout lerna.json ensured that two versions weren't published, and that the final version number change was only a single increment.
I've reverted to the simpler command-line with just the addition of --exact, and I can't reproduce the issue I had earlier, so I'll commit the simpler line.
gulpfile.js
Outdated
| var version = lernaJSON.version; | ||
| var jsonPattern = /\"version\"\: \"[\.0-9\-a-z]*\"/; | ||
| var jsPattern = /version\: \'[\.0-9\-a-z]*\'/; | ||
| var meteorPattern = /ethereum:web3@[\.0-9\-a-z]*/; |
There was a problem hiding this comment.
This we also can remove, as we can’t modify the versions Json, this will be done by meteor publish.
Currently this is a manual thing,as meteor doesn’t allow to exclude certain folders, I have to manually copy them out to publish a release.
…e/exactVersionDependencies
…with exact versions.
| @@ -12,7 +12,7 @@ | |||
| "postinstall": "lerna bootstrap", | |||
| "build": "gulp", | |||
| "build-all": "gulp all", | |||
| "release": "lerna bootstrap; gulp; lerna publish --skip-git; gulp version;", | |||
| "release": "lerna bootstrap; lerna publish; gulp version; gulp", | |||
There was a problem hiding this comment.
Hm, but now we basically publish before we change the version globally? and the --exact is missing, which is quite essential.
There was a problem hiding this comment.
See the changes in lerna.json.
…e/exactVersionDependencies
1 similar comment
* Specify the "--exact" flag when running `lerna publish` to pin dependencies to exact released versions on all the web3-* packages. * Fixed package versioning. Fixed the `gulp version` task so that it updates all the necessary files, including `.versions` Changed the `release` npm script to update all versions (via lerna), *then* rebuild the dist files, then do the full `lerna publish` step. * Simplified the `npm run release` script, removed version update of meteor files. * Discovered a more global way of ensuring that lerna always publishes with exact versions. * Fixed blocking test in eth.sendTransaction.js
No description provided.