-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make signTransaction return a promise, fixes #1213 #1214
Conversation
This is breaking 7 tests, can you please run This was a decision i made to allow I am still torn, but it might be better to return a promise at all times. Can you fix the tests as well? |
@frozeman i will try later to fix the tests! imho returning always a promise it's the best option based on my experience, e.g. having a complex signature implies also a more complex dev ux for TypeScript.. |
Please fix the test :) |
sorry, i forgot. i will do it now. |
f2c8228
to
440285e
Compare
@frozeman tests and conflicts are fixed. have a look at the |
tests are failing on node < 7. |
Sorry for the delay. |
Currently there is a 1.0ES6 branch, but the current version is ES5 and we cant introduce now ES6 in one place here. |
440285e
to
cdf7bda
Compare
3baffe7
to
57d62ee
Compare
@frozeman done, but i strongly suggest to implement a transpiling step in the build to enable es6 usage on legacy versions. or even better port the code to typescript! 🚀 EDIT: travis seems stuck. |
CI is green. ✅ |
the PR is stale again.. |
No description provided.