Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks input type string to avoid confusing error #1254

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Checks input type string to avoid confusing error #1254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
424a1c1
Checks input type string to avoid confusing error
samsonradu Dec 25, 2017
c8734d6
remove quotes
samsonradu Dec 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/web3-eth-abi/src/formatters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ var formatInputDynamicBytes = function (value) {
* @returns {SolidityParam}
*/
var formatInputString = function (value) {
if(!_.isString(value)) {
throw new Error('Given parameter is not a valid string: ' + value);
}

var result = utils.utf8ToHex(value).replace(/^0x/i,'');
var length = result.length / 2;
var l = Math.floor((result.length + 63) / 64);
Expand Down