-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build dist into packages/web3/dist,fix #1041 #1336
Conversation
Why would you want the mist folder in the npm module? |
@frozeman for example if a web developer want to make a DApp to query on-chain block status, they just need to create a HTML page and include the dist/web3.min.js file into it. example like https://github.com/trufflesuite/truffle-contract#browser-usage |
Actually I tend to agree with @gasolin, it's convenient not to have to build it and just include it from /dist. Why do you .npmignore it on the 1.0 branch and not on the stable branch ? |
Rebased the patch. To avoid the conflict, require run @frozeman how do you think? |
Hi guys, any updates on this? I need to inject web3 directly in the browser when running feature tests with Puppeteer since I cannot have MetaMask. Since the dist folder and the |
Hey all, This should be fixed with the PR #2000. I'll provide on the next release for each module a UMD, commonJS and ESM bundle. |
The new web3 1.x package is published via
packages/web3
.The
dist/
is missing in newweb3
module because of the generateddist/
is not located inweb3/packages/web3/dist
.The patch
web3/dist
toweb3/packages/web3/dist
so npm publish will includedist/
folder in web3 module.