Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build dist into packages/web3/dist,fix #1041 #1336

Closed
wants to merge 1 commit into from
Closed

Conversation

gasolin
Copy link

@gasolin gasolin commented Jan 30, 2018

The new web3 1.x package is published via packages/web3.
The dist/ is missing in new web3 module because of the generated dist/ is not located in web3/packages/web3/dist.

The patch

  • fixed links in packages/web3/README.md
  • move web3/dist to web3/packages/web3/dist so npm publish will include dist/ folder in web3 module.

@coveralls
Copy link

coveralls commented Jan 30, 2018

Coverage Status

Coverage remained the same at 85.741% when pulling d739449 on gasolin:1.0 into dd55daa on ethereum:1.0.

@coveralls
Copy link

coveralls commented Jan 30, 2018

Coverage Status

Coverage remained the same at 85.63% when pulling 5814b84 on gasolin:1.0 into c0e727e on ethereum:1.0.

@frozeman
Copy link
Contributor

frozeman commented Feb 1, 2018

Why would you want the mist folder in the npm module?

@gasolin
Copy link
Author

gasolin commented Feb 1, 2018

@frozeman for example if a web developer want to make a DApp to query on-chain block status, they just need to create a HTML page and include the dist/web3.min.js file into it.

example like https://github.com/trufflesuite/truffle-contract#browser-usage

@guix77
Copy link

guix77 commented Mar 15, 2018

Actually I tend to agree with @gasolin, it's convenient not to have to build it and just include it from /dist. Why do you .npmignore it on the 1.0 branch and not on the stable branch ?

@gasolin
Copy link
Author

gasolin commented Apr 21, 2018

Rebased the patch. To avoid the conflict, require run npm build command to generate packages/web3/dist/ after apply this patch.

@frozeman how do you think?

@slyfox42
Copy link

slyfox42 commented Oct 2, 2018

Hi guys, any updates on this? I need to inject web3 directly in the browser when running feature tests with Puppeteer since I cannot have MetaMask. Since the dist folder and the web3.min.js file is not included I have to use RawGit to point to the minified file on the repo, which works but is not ideal.

@nivida
Copy link
Contributor

nivida commented Nov 29, 2018

Hey all,

This should be fixed with the PR #2000. I'll provide on the next release for each module a UMD, commonJS and ESM bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants