Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set XHR object timeout; #1473

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Set XHR object timeout; #1473

merged 1 commit into from
Apr 19, 2018

Conversation

Fi1osof
Copy link
Contributor

@Fi1osof Fi1osof commented Mar 17, 2018

No description provided.

@Fi1osof
Update index.js
2587308 
Set XHR object timeout;
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 85.875% when pulling 2587308 on Fi1osof:patch-1 into 926ba43 on ethereum:1.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 85.875% when pulling 2587308 on Fi1osof:patch-1 into 926ba43 on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 85.875% when pulling 2587308 on Fi1osof:patch-1 into 926ba43 on ethereum:1.0.

@frozeman
Copy link
Contributor

Why setting it to 0 by default?

@Fi1osof
Copy link
Contributor Author

Fi1osof commented Apr 14, 2018

This reason: https://github.com/Fi1osof/web3.js/blob/6816ce526981257bc1c81942366b71be1de357fe/packages/web3-providers-http/src/index.js#L33
and this https://github.com/Fi1osof/web3.js/blob/6816ce526981257bc1c81942366b71be1de357fe/packages/web3-providers-http/src/index.js#L66

frozeman
frozeman approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@frozeman frozeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real reason is: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/timeout; 0 means no timeout

@frozeman frozeman merged commit e2c79ee into web3:1.0 Apr 19, 2018
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@Fi1osof @nachomazzara
Update index.js (web3#1473)
45169de 
Set XHR object timeout;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fi1osof @coveralls @frozeman