Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shh clearSubscriptions fixed #1886

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Shh clearSubscriptions fixed #1886

merged 3 commits into from
Sep 6, 2018

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Aug 17, 2018

fixes #1466

@nivida nivida requested a review from frozeman August 17, 2018 09:53
@coveralls
Copy link

coveralls commented Aug 17, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 83.169% when pulling 0ebccde on issue/1466 into 3649dba on 1.0.

@frozeman frozeman merged commit 326e42f into 1.0 Sep 6, 2018
@nivida nivida deleted the issue/1466 branch November 19, 2018 02:32
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@nivida @nachomazzara
clearSubscriptions fixed (web3#1886)
b328c62
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees

@frozeman frozeman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web3.shh.clearSubscriptions throws TypeError and fails
3 participants
@nivida @coveralls @frozeman