Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-eth-personal types and tests #2130

Merged
merged 13 commits into from
Dec 17, 2018
Merged

web3-eth-personal types and tests #2130

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
913b4c3
all eth-personal types and tests
Huanzhang89 Dec 15, 2018
d97578f
remove TS from package dependency
Huanzhang89 Dec 16, 2018
8acc968
fix personal constructor and update PersonalClass in test
Huanzhang89 Dec 16, 2018
b19e21d
remove SignedTransaction interface and switch to Transaction
Huanzhang89 Dec 16, 2018
b8f6fc4
remove unused imports and also BatchRequest, change PersonalClass to …
Huanzhang89 Dec 16, 2018
e82424e
fix formatting
Huanzhang89 Dec 16, 2018
6927331
add test for signTransaction callback and remove linebreaks between s…
Huanzhang89 Dec 16, 2018
896320b
fix return type for unlockAccount and update documentation
Huanzhang89 Dec 16, 2018
ab29c7d
remove linebreaks for ecRecover
Huanzhang89 Dec 16, 2018
f78649d
remove unused import
Huanzhang89 Dec 16, 2018
9881f1d
Update unlock duration docs
joshstevens19 Dec 17, 2018
28a011f
Update `unlockAccount` to return `Promise<boolean>`
joshstevens19 Dec 17, 2018
5f7c02e
Fix `unlockAccount` tests
joshstevens19 Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/web3-eth-personal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,13 @@ Parameters
2. ``password`` - ``String`` - The password of the account.
3. ``unlockDuration`` - ``Number`` - The duration for the account to remain unlocked.

-------
Returns
-------


``Promise`` returns ``void``
nivida marked this conversation as resolved.
Show resolved Hide resolved

-------
Example
-------
Expand Down
4 changes: 4 additions & 0 deletions packages/web3-eth-personal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ const personal = new Personal(
);
```

## Types

If you are using TypeScript all the types are defined in the `index.d.ts` file.


[docs]: http://web3js.readthedocs.io/en/1.0/
[repo]: https://github.com/ethereum/web3.js
Expand Down
Loading