Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signTransaction should return Promise<SignedTransaction> #2217

Merged
merged 1 commit into from
Jan 27, 2019
Merged

fix: signTransaction should return Promise<SignedTransaction> #2217

merged 1 commit into from
Jan 27, 2019

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented Jan 26, 2019 •
edited
Loading

Description

signTransaction should return Promise<SignedTransaction> in typings

  • Bug fix
  • New feature
  • Breaking change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • [] I have tested my code on the live network.

@joshstevens19 joshstevens19 requested a review from nivida January 26, 2019 22:48
@joshstevens19 joshstevens19 mentioned this pull request Jan 26, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 2d8c551 on joshstevens19:fix/types/signTransaction into 2cfa2ea on ethereum:1.0.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 2d8c551 on joshstevens19:fix/types/signTransaction into 2cfa2ea on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 2d8c551 on joshstevens19:fix/types/signTransaction into 2cfa2ea on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 2d8c551 on joshstevens19:fix/types/signTransaction into 2cfa2ea on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 2d8c551 on joshstevens19:fix/types/signTransaction into 2cfa2ea on ethereum:1.0.

@joshstevens19 joshstevens19 mentioned this pull request Jan 26, 2019
Closed
16 tasks
@nivida nivida merged commit ec585b1 into web3:1.0 Jan 27, 2019
@lucashenning lucashenning mentioned this pull request Jan 27, 2019
Closed
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshstevens19 @coveralls @nivida