Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install @types/node so you do not need to add types > node in … #2219

Merged
merged 2 commits into from
Jan 27, 2019
Merged

fix: install @types/node so you do not need to add types > node in … #2219

merged 2 commits into from
Jan 27, 2019

Conversation

joshstevens19
Copy link
Contributor

tsconfig.json

Description

When you use the typings on a ts project which isnt a node project you have to manually go into your tsconfig > types and add node. Importing node types itself in the dependencies of the packages which use them will solve that.

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@joshstevens19 joshstevens19 requested a review from nivida January 27, 2019 00:51
@coveralls
Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage remained the same at 92.704% when pulling b0041eb on joshstevens19:fix/types/node-typing-error into ec585b1 on ethereum:1.0.

@nivida nivida added the Types Incorrect or missing types label Jan 27, 2019
@nivida nivida merged commit d816865 into web3:1.0 Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants