Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static providers property improved #2227

Merged
merged 12 commits into from
Jan 27, 2019
Merged

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 27, 2019

Description

Fixes the static providers property on the AbstractWeb3Module.

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage increased (+0.3%) to 92.957% when pulling 19a8af4 on fix/abstract-web3-module-providers into 599c52e on 1.0.

@nivida nivida changed the title [WIP] Static providers property improved Static providers property improved Jan 27, 2019
@nivida nivida merged commit 90223f7 into 1.0 Jan 27, 2019
@nivida nivida deleted the fix/abstract-web3-module-providers branch January 27, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants