fix: patch the angular browser.js
to allow `{crypto: true, stream: …
#2262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…true`
Description
When you install
web3
on a angular app and try to build with theangular-cli
it will not work without writing your ownpatch
script. This is because we have to replace thenode:false
in the/angular-cli-files/models/webpack-configs/browser.js
withnode: {crypto: true, stream: true}
to allow web3 to work with angular (as they enforcenode: false
which will not allowweb3
to work).Explained more in here: #2260 (comment)
I have wrote a
angular-patch.js
script which will run onpost-install
and handle all this for them. I have checked to make sure it only runs if they are installing web3 within a angular app.Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct