Fix decodeLog() for non indexed params #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `decodeLog()` for non indexed params.
The issue can be reproduced for events like this:
```
event Authorize(
bytes32 indexed platformId,
bytes32 indexed uid,
address indexed user,
AuthorizationRequest request
);
```
It is cause by `_mapTypes(types)` used in `decodeParameters(outputs, bytes)` (`var res = this.ethersAbiCoder.decode(this._mapTypes(outputs), "0x".concat(bytes.replace(/0x/i, '')));`) which returns `[ { indexed: false, name: 'request', type: 'address' } ]` for `types = outputs = [null, null, null, {"indexed":false,"name":"request","type":"address"}]` passed as argument.
So when the iteration `outputs.forEach(function (output, i) {}` is performed the `returnValues` do not get `res[i]` assigned correctly because the index is shifted due to empty types cleanup.
The fix might be linked to the following issue: web3#2268
nivida
suggested changes
Feb 4, 2019
@nivida Done |
2 similar comments
|
@nivida I see Travis failing due to other tests/linting checks performed. How can i help to fix it? |
nivida
approved these changes
Feb 6, 2019
|
@AlexanderC Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
decodeLog()for non indexed params.Description
The issue can be reproduced for events like this:
It is cause by
_mapTypes(types)used indecodeParameters(outputs, bytes)(var res = this.ethersAbiCoder.decode(this._mapTypes(outputs), "0x".concat(bytes.replace(/0x/i, '')));) which returns[ { indexed: false, name: 'request', type: 'address' } ]fortypes = outputs = [null, null, null, {"indexed":false,"name":"request","type":"address"}]passed as argument.So when the iteration
outputs.forEach(function (output, i) {}is performed thereturnValuesdo not getres[i]assigned correctly because the index is shifted due to empty types cleanup.Fixes #2268
Type of change
Checklist:
npm run testin the root folder with success and extended the tests if necessary.npm run buildin the root folder and tested it in the browser and with node.