Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPastEvents JSON-RPC methods updated #2338

Merged
merged 9 commits into from
Feb 7, 2019
Merged

getPastEvents JSON-RPC methods updated #2338

merged 9 commits into from
Feb 7, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 7, 2019 •
edited
Loading

Description

Fixes #2311

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added the In Progress Currently being worked on label Feb 7, 2019
@nivida nivida changed the title getPastLogs address property added to options getPastLogs JSON-RPC methods updated Feb 7, 2019
@nivida nivida changed the title getPastLogs JSON-RPC methods updated getPastEvents JSON-RPC methods updated Feb 7, 2019
@nivida nivida removed the In Progress Currently being worked on label Feb 7, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.02% when pulling 6ee7371 on issue/getPastEvents into fffc0bd on 1.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.02% when pulling 6ee7371 on issue/getPastEvents into fffc0bd on 1.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.02% when pulling 6ee7371 on issue/getPastEvents into fffc0bd on 1.0.

@nivida nivida merged commit a770407 into 1.0 Feb 7, 2019
This was referenced Feb 7, 2019
Closed
Closed
@nivida nivida deleted the issue/getPastEvents branch February 8, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web3@1.0.0-beta.41] getPastEvents not working - {"code":-32603,"message":"request failed or timed out"}
2 participants
@nivida @coveralls