Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an interface of EthereumProvider.send #2355

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Fix an interface of EthereumProvider.send #2355

merged 3 commits into from
Feb 10, 2019

Conversation

odanado
Copy link
Contributor

@odanado odanado commented Feb 8, 2019

Description

Fixes #2329

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Feb 8, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.065% when pulling 914f375 on odanado:issue/2329 into 80325f6 on ethereum:1.0.

@nivida nivida added the Types Incorrect or missing types label Feb 9, 2019
@nivida nivida merged commit 35ebbca into web3:1.0 Feb 10, 2019
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mistake a typing of EthereumProvider.send
3 participants
@odanado @coveralls @nivida