-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objects
to any
on typing's return + dtslint fix + general test fixes
#2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshstevens19
changed the title
@types/objects to any return types
Mar 15, 2019
objects
to any
on typing's return
joshstevens19
changed the title
Mar 15, 2019
objects
to any
on typing's returnobjects
to any
on typing's return + fix dtslint build
joshstevens19
changed the title
Mar 15, 2019
objects
to any
on typing's return + fix dtslint buildobjects
to any
on typing's return
joshstevens19
changed the title
Mar 15, 2019
objects
to any
on typing's returnobjects
to any
on typing's return + dtslint fix + general test fixes
nivida
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return properties should never be a
object
they should beany
if we can not write generic types for it. If it returns aobject
we get issues like this:This PR fixes this and should be the general rule for any return types that we can not write a interface for. Obviously we should be trying to write a interface for everything but there are conditions where you have to use
any
. Fixed this throughout. Even if the types are not in the public API this is what we should follow.This PR will also fix some bad test typings + dstlint.
dtslint has been rolled back to a fix version of
0.4.2
and as Microsoft have now exposeddefinitelytyped-header-parser
as anpm
page i have brought that into our dev dependencies which allows it to work on node 8 + node 9 + node 10 + node 11:10 builds on Travis. This is now all working as expected and should be merged into master ASAP to avoid merge conflicts ofpackage-locks.json
files and to fix master build. 👍Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct