Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use genuine BN type #2529

Merged
merged 9 commits into from
Mar 25, 2019
Merged

Use genuine BN type #2529

merged 9 commits into from
Mar 25, 2019

Conversation

vshab
Copy link

@vshab vshab commented Mar 19, 2019

Description

Don't wrap BN but use type from BN library to improve compatibility with BN operations. Without this change this code is invalid:

const bigNumber = new BN(3);

fromWei(bigNumber.add(new BN(100)));

Fixes #2350

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

coveralls commented Mar 19, 2019

Coverage Status

Coverage decreased (-0.009%) to 98.672% when pulling b1f49a5 on vshab:fix/bn-type into 22a190c on ethereum:1.0.

packages/web3-core/types/index.d.ts Show resolved Hide resolved
packages/web3-utils/types/index.d.ts Show resolved Hide resolved
@nivida nivida added the Types Incorrect or missing types label Mar 19, 2019
@vshab
Copy link
Author

vshab commented Mar 25, 2019

@nivida CI fixed

@nivida nivida merged commit f8cb5c6 into web3:1.0 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[types][web3-utils] Use bn.js directly for class BN instead of wrapper
3 participants