Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write better types for ens and update the docs #2618

Merged
merged 10 commits into from
Apr 1, 2019
Merged

Write better types for ens and update the docs #2618

merged 10 commits into from
Apr 1, 2019

Conversation

joshstevens19
Copy link
Contributor

Description

I have wrote better typing's for the ENS module based on the code and also updated the docs as i went along. 👍

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@joshstevens19 joshstevens19 requested a review from nivida March 30, 2019 12:03
@coveralls
Copy link

coveralls commented Mar 30, 2019

Coverage Status

Coverage remained the same at 95.4% when pulling 259aa47 on joshstevens19:types/web-ens into 9f3c712 on ethereum:1.0.

@joshstevens19 joshstevens19 added the Types Incorrect or missing types label Mar 30, 2019
@nivida nivida merged commit a5225ca into web3:1.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants