Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to Wallet type #2619

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Add index to Wallet type #2619

merged 3 commits into from
Apr 1, 2019

Conversation

vshab
Copy link

@vshab vshab commented Mar 30, 2019

Description

Currently there is no way to access accounts in wallet. This change make it possible.

web3.eth.accounts.wallet[0].address;

Type of change

  • Bug fix
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.4% when pulling 8ae4bb3 on vshab:fix/add-wallet-index into 9f3c712 on ethereum:1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.4% when pulling 8ae4bb3 on vshab:fix/add-wallet-index into 9f3c712 on ethereum:1.0.

Copy link
Contributor

@joshstevens19 joshstevens19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR 👍 @nivida can you merge please.

@joshstevens19 joshstevens19 added the Types Incorrect or missing types label Mar 30, 2019
@nivida nivida merged commit 26987f6 into web3:1.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants