Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supportsSubscriptions added to providers #2632

Merged
merged 9 commits into from
Apr 3, 2019
Merged

supportsSubscriptions added to providers #2632

merged 9 commits into from
Apr 3, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Apr 2, 2019

This method will be used internally and can be used in the custom modules created with the Web3 Module API.

Description

Fixes #1015

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Apr 2, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.29% when pulling 73f6878 on issue/1015 into 02f2866 on 1.0.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage increased (+0.002%) to 95.374% when pulling 6aa8ebb on issue/1015 into 9e3d016 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Apr 3, 2019
@nivida nivida merged commit a004d49 into 1.0 Apr 3, 2019
@nivida nivida deleted the issue/1015 branch April 3, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants