fix: make auto-resolve to the root module when importing typings #2645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment when you auto-import types VSCODE resolves it to for which is awesome. In web3 case it resolves it wrongly.. example:
it should be
It shouldn't resolve with the
types
at the end as we defined it intypes
in thepackage.json
s. Looking at thetypes
in thepackage.json
s they're incorrect."types": "types"
should be >"types": "types/index.d.ts"
My changes will fix this so it auto-imports straight to the module itself.
Most people wont see the issues when going to the types path but once you webpack it for example in angulars cli it throws a error until you remove it. Again this will resolve all of that.
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct