Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes in some packages #2699

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Minor changes in some packages #2699

merged 3 commits into from
Apr 17, 2019

Conversation

princesinha19
Copy link
Contributor

@princesinha19 princesinha19 commented Apr 17, 2019

Description

Changed readme section os some module. Also, changed some typings and package dependency.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@princesinha19 princesinha19 changed the title fixes Minor changes in some packages Apr 17, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.545% when pulling db1a4e8 on princesinha19:readme-fix into b18a1eb on ethereum:1.0.

@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage remained the same at 95.55% when pulling 1a02a98 on princesinha19:readme-fix into 18eb61e on ethereum:1.0.

docs/web3-eth-txpool.rst Outdated Show resolved Hide resolved
packages/web3-eth-miner/types/index.d.ts Show resolved Hide resolved
packages/web3-eth-miner/types/index.d.ts Outdated Show resolved Hide resolved
packages/web3-eth-personal/package.json Show resolved Hide resolved
packages/web3-eth-txpool/types/index.d.ts Outdated Show resolved Hide resolved
@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Apr 17, 2019
@nivida nivida requested a review from joshstevens19 April 17, 2019 07:54
@nivida nivida removed the In Progress Currently being worked on label Apr 17, 2019
@nivida nivida merged commit 7a5eab3 into web3:1.0 Apr 17, 2019
@princesinha19 princesinha19 deleted the readme-fix branch April 18, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants