Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve parity nodes invalid "eth_getBlockByNumber" JSONRPC call #2847

Merged
merged 11 commits into from
May 31, 2019
Merged

Resolve parity nodes invalid "eth_getBlockByNumber" JSONRPC call #2847

merged 11 commits into from
May 31, 2019

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented May 26, 2019

Description

If you send a transaction with a parity node web3 does not take into account that parity nodes can return the transaction receipt even if the transaction has not been mined. Unlike geth who return it once it has been mined. This causes a invalid JSONRPC call to "eth_getBlockByNumber" passing in a null block number causing the nodes to throw bad requests. This change just makes sure it does not call "eth_getBlockByNumber" until it has been mined.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.953% when pulling 2b23d48 on joshstevens19:resolve-parity-get-block-by-block-number-error into 6961fa2 on ethereum:1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.953% when pulling 2b23d48 on joshstevens19:resolve-parity-get-block-by-block-number-error into 6961fa2 on ethereum:1.0.

@coveralls
Copy link

coveralls commented May 26, 2019

Coverage Status

Coverage increased (+0.001%) to 95.953% when pulling 3f2b18d on joshstevens19:resolve-parity-get-block-by-block-number-error into 5683436 on ethereum:1.0.

@joshstevens19 joshstevens19 changed the title Resolve parity invalid "eth_getBlockByNumber" JSONRPC call Resolve parity nodes invalid "eth_getBlockByNumber" JSONRPC call May 26, 2019
@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on labels May 28, 2019
@nivida nivida removed the In Progress Currently being worked on label May 31, 2019
@nivida nivida merged commit 9f95015 into web3:1.0 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants