-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve parity nodes invalid "eth_getBlockByNumber" JSONRPC call #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get fork in sync with local fork
…yet and web3 calls "eth_getBlockByNumber" JSONRPC call with a null block number
1 similar comment
joshstevens19
changed the title
Resolve parity invalid "eth_getBlockByNumber" JSONRPC call
Resolve parity nodes invalid "eth_getBlockByNumber" JSONRPC call
May 26, 2019
nivida
added
Enhancement
Includes improvements or optimizations
In Progress
Currently being worked on
labels
May 28, 2019
nivida
suggested changes
May 30, 2019
nivida
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you send a transaction with a parity node web3 does not take into account that parity nodes can return the transaction receipt even if the transaction has not been mined. Unlike geth who return it once it has been mined. This causes a invalid JSONRPC call to "eth_getBlockByNumber" passing in a null block number causing the nodes to throw bad requests. This change just makes sure it does not call "eth_getBlockByNumber" until it has been mined.
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct